Summary: | Transaction type is empty in cash register statistics wizard report | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Reports | Assignee: | Ivan Dziuba <ivan.dziuba> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, ivan.dziuba, jonathan.druart, kyle, martin.renvoize, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.02,20.11.09
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 29271 | ||
Attachments: |
Bug 28264: Transaction type is empty is cash register statistics wizard report
Bug 28264: Transaction type is empty is cash register statistics wizard report Bug 28264: (QA follow-up) Impliment fix for debit_type_code |
Description
Caroline Cyr La Rose
2021-04-29 15:58:27 UTC
Created attachment 120642 [details] [review] Bug 28264: Transaction type is empty is cash register statistics wizard report To test: 1) Go into a patron file and add some manual fees and pay them 2) Go to Reports > Statistics wizards > Cash register 3) In the form, choose Transaction type: All transactions 4) Click "Submit" 5) Note that the Transaction type column is empty 6) In the form, choose Output: To a file 7) Click "Submit" 8) Open the file in a spreadsheet software (I use LibreOffice) 9) The Transaction type column IS NOT empty Created attachment 120824 [details] [review] Bug 28264: Transaction type is empty is cash register statistics wizard report To test: 1) Go into a patron file and add some manual fees and pay them 2) Go to Reports > Statistics wizards > Cash register 3) In the form, choose Transaction type: All transactions 4) Click "Submit" 5) Note that the Transaction type column is empty 6) In the form, choose Output: To a file 7) Click "Submit" 8) Open the file in a spreadsheet software (I use LibreOffice) 9) The Transaction type column IS NOT empty Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 120825 [details] [review] Bug 28264: (QA follow-up) Impliment fix for debit_type_code The fix for the debit_type line was also missing. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial correction, going straight for QA on this one.. Passed. Pushed to master for 21.11, thanks to everybody involved! Congratulations, Ivan, for your first patch pushed! Pushed to 21.05.x for 21.05.02 Pushed to 20.11.x for 20.11.09 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. I see this problem in a 20.11.16 :( I've tried to fix it in 20.11, but I am a little puzzled, the code seems to be different than in master. It's possibly because we are missing bug 29271 in 20.11. |