| Summary: | Cart in OPAC doesn't sent mails if surname or firstname contains diacritics | ||
|---|---|---|---|
| Product: | Koha | Reporter: | verolencinas <verolencinas> |
| Component: | OPAC | Assignee: | Bugs List <koha-bugs> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | dcook, f.kolovos |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
|
Description
verolencinas
2021-05-01 15:39:34 UTC
Confirmed in master. Hello, Upon further investigation, the problem does not seem to be solely with the diacritics in the user's name, but with ANY character other than the ones forming an email address in the user's email. The purpose is to form a combination of the user's fullname and the email, in the form John Doe <john.doe@test.com>, but it does not pass the Email::Valid->addresses() method in Koha::Email, throwing a BadParameter exception in line 112. I guess that this method is very strict in validating the email address format One quick workaround would be to change the line 62 in /usr/share/koha/opac/cgi-bin/opac/opac-sendbasket.pl from my $email_replyto = $patron->firstname . " " . $patron->surname . " <$user_email>"; to my $email_replyto = $user_email; It was checked and it works. Further work could include to first validate the email address and afterwards to include the user's firstname and lastname along with the "<",">" characters around the email. |