Bug 28283

Summary: 'Quantity received' should have inputmode="numeric"
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: AcquisitionsAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: david, fridolin.somers, nick, oleonard, severine.queune, wainuiwitikapark
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28135
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
21.05.00
Circulation function:
Bug Depends on:    
Bug Blocks: 26926    
Attachments: Bug 28283: Add `inputmode="numeric"` to quantity on orderreceive
Bug 28283: Add `inputmode="numeric"` to quantity on orderreceive
Bug 28283: Add `inputmode="numeric"` to quantity on orderreceive
Bug 28283: Add `inputmode="numeric"` to quantity on orderreceive

Description Martin Renvoize (ashimema) 2021-05-04 10:10:38 UTC
ACC2 suggests 'inputmode="numeric"' for numeric inputs. This is missing on the acquisitions item receipt page for the 'Quantity received' input.
Comment 1 Martin Renvoize (ashimema) 2021-05-04 10:17:19 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize (ashimema) 2021-05-04 10:21:00 UTC
Created attachment 120433 [details] [review]
Bug 28283: Add `inputmode="numeric"` to quantity on orderreceive

This patch adds an inputmode to the quantity field on the order receive
page in acquisitions.

Test plan
1. Go to Acquisitions -> Vendor -> Invoices -> Invoice -> Go to receipt
   page -> Receive.
2. Note that the 'Quantity received' input has an inputmode now.
3. Note that the 'Quantity received' input also has a pattern attribute.
4. Note that you should not be able to enter non-integer values.
Comment 3 Owen Leonard 2021-05-07 12:12:41 UTC
Created attachment 120687 [details] [review]
Bug 28283: Add `inputmode="numeric"` to quantity on orderreceive

This patch adds an inputmode to the quantity field on the order receive
page in acquisitions.

Test plan
1. Go to Acquisitions -> Vendor -> Invoices -> Invoice -> Go to receipt
   page -> Receive.
2. Note that the 'Quantity received' input has an inputmode now.
3. Note that the 'Quantity received' input also has a pattern attribute.
4. Note that you should not be able to enter non-integer values.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Katrin Fischer 2021-05-09 11:47:04 UTC
Created attachment 120736 [details] [review]
Bug 28283: Add `inputmode="numeric"` to quantity on orderreceive

This patch adds an inputmode to the quantity field on the order receive
page in acquisitions.

Test plan
1. Go to Acquisitions -> Vendor -> Invoices -> Invoice -> Go to receipt
   page -> Receive.
2. Note that the 'Quantity received' input has an inputmode now.
3. Note that the 'Quantity received' input also has a pattern attribute.
4. Note that you should not be able to enter non-integer values.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Jonathan Druart 2021-05-11 13:39:36 UTC
Pushed to master for 21.05, thanks to everybody involved!
Comment 6 Fridolin Somers 2021-05-12 15:18:20 UTC
Not pushed to 20.11.x