| Summary: | Add ability to force re-run of a particular DB update | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Installation and upgrade (command-line installer) | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED INVALID | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, dcook, fridolin.somers, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | Bug 28301: Add forced run of particular DB update | ||
|
Description
Nick Clemens (kidclamp)
2021-05-07 13:06:37 UTC
Created attachment 120689 [details] [review] Bug 28301: Add forced run of particular DB update This patch adds a --forcedversion option to the updatedatabase script in order to allow testing of a particular update To test: 1 - Apply patch 2 - Pick a DB update that will fail if rerun 3 - perl /kohadevbox/koha/installer/data/mysql/updatedatabase.pl --forcedversion="3.21.00.041" 4 - Confirm it ran, you should get an error :-) 5 - Check the version system preference, confirm it is unchanged SELECT value FROM systempreference WHERE variable='Version'; Can you rebase it on top of bug 25078 please? If it can wait I can do it when it's pushed to master. Very interesting. Needs rewrite since bug 25078 right ? I think it's actually no longer needed with bug 25078. (In reply to Jonathan Druart from comment #4) > I think it's actually no longer needed with bug 25078. But how do you run a particular DBRev perl file ? (In reply to Fridolin Somers from comment #5) > (In reply to Jonathan Druart from comment #4) > > I think it's actually no longer needed with bug 25078. > > But how do you run a particular DBRev perl file ? What would be the use case? Now the update process stops when an error happens. For example checking that it can be run several times. (In reply to Fridolin Somers from comment #7) > For example checking that it can be run several times. It should be done when it's still an atomic update :) Once it's in dbrev, such test should have been done already. I am not against the idea, but I don't understand what it will bring us. (In reply to Jonathan Druart from comment #8) > It should be done when it's still an atomic update :) Ahhhh correct Is this bug still relevant (from the comments)? If it is, I will have a go at testing... I don't think so. Nick, please reopen if you disagree. |