|
Description
Martin Renvoize (ashimema)
2021-05-13 10:49:17 UTC
Created attachment 120917 [details] [review] Bug 28346: Add classes to account action buttons This patch adds identifiable classes to each action button that may be displayed next to an accountline on the borrower account page. Hi Martin, Just one button missing a unique class, which is the cancel charge button: button type="submit" class="btn btn-default btn-xs" Created attachment 121108 [details] [review] Bug 28346: Add classes to account action buttons This patch adds identifiable classes to each action button that may be displayed next to an accountline on the borrower account page. Created attachment 121109 [details] [review] Bug 28346: (QA follow-up) Correct silly mistake with cancel-action This patch moves the cancel-action class introduced in the previous commit from the font-icon to the button where it should be. Good catch, seems I attached the class to the wrong element.. Doh! What about the 'Details' button that goes to 'accountline-details.pl?accountlines_id=X'. That one should have a class as well right? Did I miss a case... 'details-action' looks like that one to me. (In reply to Martin Renvoize from comment #7) > Did I miss a case... 'details-action' looks like that one to me. Ah, yes I see 'details-action' but it on the icon element, not the button: <i class="fa fa-list details-action"></i> Created attachment 121118 [details] [review] Bug 28346: (QA follow-up) Correct silly mistake with details-action This patch moves the details-action class introduced in the first commit from the font-icon to the button where it should be. Clearly I was having a bad day when I wrote this patch!.. Two simple follow-ups later, hopefully I've got it this time! Created attachment 121120 [details] [review] Bug 28346: Add classes to account action buttons This patch adds identifiable classes to each action button that may be displayed next to an accountline on the borrower account page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 121121 [details] [review] Bug 28346: (QA follow-up) Correct silly mistake with cancel-action This patch moves the cancel-action class introduced in the previous commit from the font-icon to the button where it should be. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 121122 [details] [review] Bug 28346: (QA follow-up) Correct silly mistake with details-action This patch moves the details-action class introduced in the first commit from the font-icon to the button where it should be. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Just wondering: if they are supposed to be and remain unique, should they not be ids? (In reply to Katrin Fischer from comment #14) > Just wondering: if they are supposed to be and remain unique, should they > not be ids? I've reworded the bug title.. I didn't mean ID's.. I meant Classes, one per action type. Could we squash this patches? In this tiny change it makes sense to have a single patch. Also - payout-amount - invoice-print - receipt-print => should have the -action suffix for consistency. Created attachment 123923 [details] [review] Bug 28346: Add classes to account action buttons This patch adds identifiable classes to each action button that may be displayed next to an accountline on the borrower account page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 123924 [details] [review] Bug 28346: (QA follow-up) Add `-action` for consistency Patches squashed and follow-up added to address -action consistency concerns. Feel free to squash the follow-up on push.. I was not entirely sure about updating the pre-existing 'void' class and hence kept the patch distinct for now. Created attachment 123953 [details] [review] Bug 28346: Add classes to account action buttons This patch adds identifiable classes to each action button that may be displayed next to an accountline on the borrower account page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123954 [details] [review] Bug 28346: (QA follow-up) Add `-action` for consistency Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! |