| Summary: | Regression: Batch item deletion no longer shows which items were not removed | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Donna <bwsdonna> |
| Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, jonathan.druart, lisettepalouse+koha, lnilsson, victor |
| Version: | unspecified | Keywords: | Manual |
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31630 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This restores and improves the messages displayed when batch deleting items (Tools > Catalog > Batch item deletion).
The messages displayed are:
- "Warning, the following barcodes were not found:", followed by a list of barcodes
- "Warning, the following items cannot be deleted:", followed by a list of barcodes
|
Version(s) released in: |
21.11.00,21.05.01,20.11.07
|
| Circulation function: | |||
| Bug Depends on: | 8132 | ||
| Bug Blocks: | 31630 | ||
| Attachments: |
Bug 28353: Display a list of items that cannot be deleted
Bug 28353: Display a list of items that cannot be deleted Bug 28353: Display a list of items that cannot be deleted |
||
|
Description
Donna
2021-05-13 21:47:00 UTC
This is a big problem for our libraries. I do cataloging for multiple libraries and librarians send me large lists of barcodes to delete. The new feature is not efficient. When I use this tool, I need the warnings on the results page to say which barcodes were not deleted and why, so I can refer those items back to the librarians to follow up on. Thanks, LeeAnn (In reply to Donna from comment #0) > The results page should show a list of items in the batch that were not able > to be deleted. +1 This would be much more helpful than the current setup. Lisette Created attachment 121089 [details] [review] Bug 28353: Display a list of items that cannot be deleted We used to display a list of items that cannot be deleted (checked out or on hold) on the Batch item deletion tool. With bug 8132 we improve the error handling, but the info is spread in the table. This patch adds, at the top of the page, the list of items (barcode) that cannot be removed. With this patch I get: https://snipboard.io/phjBsA.jpg Would that work for you? Yes that is helpful. Thanks (In reply to LeeAnn Nilsson from comment #5) > Yes that is helpful. Thanks Hi Leann, would you be able to sign this off? The sandboxes should work in this case and we just updated the instructions :) https://wiki.koha-community.org/wiki/Sandboxes Also happy to help if you have any questions. Created attachment 121504 [details] [review] Bug 28353: Display a list of items that cannot be deleted We used to display a list of items that cannot be deleted (checked out or on hold) on the Batch item deletion tool. With bug 8132 we improve the error handling, but the info is spread in the table. This patch adds, at the top of the page, the list of items (barcode) that cannot be removed. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using koha-testing-docker).
Test plan:
1. Place a hold for an item and note the barcode
2. Check out an item and note the barcode
3. Go to the batch delete item tool (Tools > Catalog > Batch item deletion)
and in the barcode list enter:
. The barcodes from step 1 and 2
. An invalid barcode (such as 'XYZ'),
. A barcode for an item that can be deleted (= not checked out, not on hold)
and click 'Continue'
5. The batch item deletion page will show this message:
. 'Warning, the following barcodes were not found:", followed by a list of barcodes
(it should list the invalid barcode entered in step 3)
6. Select all the items and click 'Delete selected items'
7. The message says: '1 item(s) deleted'
8. Apply the patch
9. Repeat step 3:
10. The batch item deletion page will show these messages:
. 'Warning, the following barcodes were not found:", followed by a list of barcodes
- "Warning, the following items cannot be deleted:", followed by a list of barcodes
11. Click 'Delete selected items", the resulting mesage says '1 item(s) deleted'
12. Sign off!
Created attachment 121577 [details] [review] Bug 28353: Display a list of items that cannot be deleted We used to display a list of items that cannot be deleted (checked out or on hold) on the Batch item deletion tool. With bug 8132 we improve the error handling, but the info is spread in the table. This patch adds, at the top of the page, the list of items (barcode) that cannot be removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.01 Pushed to 20.11.x for 20.11.07 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. This has a closed fixed status, but has regressed again. The only warning given is an unclicked box and when deleting long lists it is hard to notice. The follow up page use to have a notification stating some barcodes were not deleted, please help. Thanks, LeeAnn (In reply to LeeAnn Nilsson from comment #15) > This has a closed fixed status, but has regressed again. The only warning > given is an unclicked box and when deleting long lists it is hard to notice. > The follow up page use to have a notification stating some barcodes were not > deleted, please help. Thanks, LeeAnn Hi LeeAnn, please report this as a new bug. When a bug has been closed and was part of a release, this is always the way to go. With a new bug, the problem will show properly in the release notes and RMaints will be alerted that they need to backport. ... you can use the 'Depends on' in the new bug to link to this one! |
