| Summary: | Link to make article reqests should display on detail page when user is not logged in | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
|
Description
Katrin Fischer
2021-05-17 06:58:03 UTC
I just retested this in 20.11:
ArticleRequestsLinkControl = Always show
- Result list: Article request link always shows
- Detail page: Article request link only shows when logged in
I think this is because of the check on the artreqpossible template variable - I suspect it can only be 1 if the user is logged in:
my $artreqpossible = $patron
? $biblio->can_article_request( $patron )
: $itemtype
? $itemtype->may_article_request
: q{};
$template->param( artreqpossible => $artreqpossible );
The code for the same variable in the result list is certainly different, but completely mysterious to me:
# BZ17530: 'Intelligent' guess if result can be article requested
$res->{artreqpossible} = ( $art_req_itypes->{ $res->{itemtype} // q{} } || $art_req_itypes->{ '*' } ) ? 1 : q{};
I am not sure how to fix this :(
In my tests in master (as of 21.06.00.022), the "request article" link shows up in search results and on the detail page regardless of the ArticleRequestsLinkControl setting. |