Summary: | Always use semicolon when preference CSVDelimiter is missing | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Tools | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | dcook |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 28327 | ||
Bug Blocks: | |||
Attachments: | Bug 28363: Always use semicolon when preference CSVDelimiter is missing |
Description
Fridolin Somers
2021-05-17 10:41:12 UTC
Created attachment 121039 [details] [review] Bug 28363: Always use semicolon when preference CSVDelimiter is missing Some places use comma as value when preference CSVDelimiter is missing or empty. From installer/data/mysql/mandatory/sysprefs.sql whe see that default install value is semicolon. This patch sets semicolon when preference CSVDelimiter is missing. "We are perl, we love semicolon ;)" Test plan : 1) With SQL, set system preference 'CSVdelimiter' to empty string. 2) Create CSV export in impacted pages 3) Check columns are separated by semicolon character https://bugs.koha-community.org/show_bug.cgi?id=28327 It seems strange to me to default to a semicolon. Shouldn't the default for Comma Separated Values be a comma? In this case we change value in installer. I propose a quick vote : comma or semicolon ? Comma makes sense I guess - I believe this would be the case now mostly? Ah HEA says : https://hea.koha-community.org/systempreferences delimiter says : - semicolon : 8925 - comma 607 CSVDelimiter has only 19 comma. But we can argue only a few install change default value. (In reply to Fridolin Somers from comment #5) > Ah HEA says : > https://hea.koha-community.org/systempreferences > > delimiter says : > - semicolon : 8925 > - comma 607 > > CSVDelimiter has only 19 comma. > > But we can argue only a few install change default value. Rereading the bug I am happy with semicolon as it appears the most consistent choice. (In reply to Fridolin Somers from comment #5) > But we can argue only a few install change default value. Exactly. I don't know why we don't have a more normal default value... |