|
Description
Jason Robb
2021-05-20 17:05:15 UTC
It would be nice to have this information on that page. Having the author display on this page would be a big help and real time saver. Created attachment 121259 [details] [review] Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear. A few things I noted during testing: If the author is in a 110 or 130 tag instead of a 100 tag it does not display. We don't have a lot of instances of this since we are a public library but it might matter to educational and special libraries. When the author is a one-named person (such as Lee in the screenshot) the display looks a little odd. It's a little confusing that the name Lee is just sort of floating there on the screen - it doesn't feel like it is connected to the title. Even with a standard author with first and last name it still doesn't feel quite connected to the title. This may not be possible, or preferable, but I wonder if it would be better to have the author display after the title on one line (see screenshot) Created attachment 121290 [details]
One-name author
Created attachment 121291 [details]
author on same line
I think Barbara is right and that the author name should be next to the title because it doesn't feel like it's connected to the title when it's placed below. Created attachment 121937 [details] [review] Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Created attachment 121940 [details] [review] Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> I believe the separator / is unnecessary. The title will already end with : or / (ISBD punctuation) and then the separator is doubled up. If we want to match with other places, maybe we should replace it with "by" as UNIMARC doesn't use punctuation. I also wonder if it would be nice to include an author option in the code for the title that takes care of that by also checking the MARC flavor... or removing additional ending punctuation. Just putting this here for now, I'd be happy with almost anything, but : / and // don't look nice right now. I agree that the "/" is unnecessary. Created attachment 129678 [details] [review] Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Created attachment 129735 [details] [review] Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Why the WONTFIX? I hope it was not my comment, I'd be happy just with the double punctuation removed. (In reply to Katrin Fischer from comment #14) > Why the WONTFIX? > > I hope it was not my comment, I'd be happy just with the double punctuation > removed. If I set this to WONTFIX, it was accidental. I believe the proper status should now be 'Signed off' Created attachment 130244 [details] [review] Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: AUTHORNAME <george@nekls.org> Created attachment 130337 [details] [review] Bug 28405: Add author for multi holds view Do we want to display the author for the multi-holds view as well? Created attachment 130534 [details] [review] Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 130535 [details] [review] Bug 28405: Add author for multi holds view Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Jonathan Druart from comment #18) > Do we want to display the author for the multi-holds view as well? Yes, but you've already done it :) I have updated George's sign-off line: Signed-off-by: AUTHORNAME <george@nekls.org> Signed-off-by: George Williams <george@nekls.org> Pushed to master for 22.05, thanks to everybody involved [U+1F984] |