Summary: | Last modification date for suggestions is wrong | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, kyle, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.11.00,21.05.03,20.11.09
|
Circulation function: | |
Bug Depends on: | 23590 | ||
Bug Blocks: | 28855 | ||
Attachments: |
Bug 28408: Add 'Last updated' column to suggestions table
Bug 28408: Add 'Last updated' column to suggestions table Bug 28408: Add 'Last updated' column to suggestions table Bug 28408: Add new column to the table settings config |
Description
Nick Clemens (kidclamp)
2021-05-20 20:05:48 UTC
Linking this to the introducing bug 23590. The last_modification_date is linked to last_modified_by - so not all changes will udpate the date. I am not sure to make this more clear, but comments on bug 23590 indicate it is the intended behaviour. See: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590#c101 Created attachment 121482 [details] [review] Bug 28408: Add 'Last updated' column to suggestions table We have specific meanings for the different dates in suggestions Managed - means the status was changed or the suggestion edited, but doesn't change if item type updated Modification - implies an edit of the subscript, not updated if status changed alone Updated - this is the date field in the DB, which is actually a timestamp The cronjob purge_suggestions.pl uses teh 'date' field For a user, a suggestion can look old in the interface, but be considered recent by the script To clear the confusion we should show the timestamp as well To test: 1 - Add a suggestion 2 - In the DB, pretend you set it in the past: UPDATE suggestions SET manageddate='2021-01-01', suggesteddate='2021-01-01', date='2021-01-01 12:12:12'; 3 - Click 'Go' In Organize by: Status 4 - Note the suggestion looks old now 5 - Check the box, and click 'Update item types with:' -> Submit 6 - Prganize by status again 7 - No change? 8 - Check the DB: SELECT date FROM suggestions; 9 - The field is updated 10 - Apply patch 11 - Organize by status again 12 - See the 'Last updated' ate set to today Created attachment 121634 [details] [review] Bug 28408: Add 'Last updated' column to suggestions table We have specific meanings for the different dates in suggestions Managed - means the status was changed or the suggestion edited, but doesn't change if item type updated Modification - implies an edit of the subscript, not updated if status changed alone Updated - this is the date field in the DB, which is actually a timestamp The cronjob purge_suggestions.pl uses teh 'date' field For a user, a suggestion can look old in the interface, but be considered recent by the script To clear the confusion we should show the timestamp as well To test: 1 - Add a suggestion 2 - In the DB, pretend you set it in the past: UPDATE suggestions SET manageddate='2021-01-01', suggesteddate='2021-01-01', date='2021-01-01 12:12:12'; 3 - Click 'Go' In Organize by: Status 4 - Note the suggestion looks old now 5 - Check the box, and click 'Update item types with:' -> Submit 6 - Prganize by status again 7 - No change? 8 - Check the DB: SELECT date FROM suggestions; 9 - The field is updated 10 - Apply patch 11 - Organize by status again 12 - See the 'Last updated' ate set to today Signed-off-by: David Nind <david@davidnind.com> Created attachment 123136 [details] [review] Bug 28408: Add 'Last updated' column to suggestions table We have specific meanings for the different dates in suggestions Managed - means the status was changed or the suggestion edited, but doesn't change if item type updated Modification - implies an edit of the subscript, not updated if status changed alone Updated - this is the date field in the DB, which is actually a timestamp The cronjob purge_suggestions.pl uses teh 'date' field For a user, a suggestion can look old in the interface, but be considered recent by the script To clear the confusion we should show the timestamp as well To test: 1 - Add a suggestion 2 - In the DB, pretend you set it in the past: UPDATE suggestions SET manageddate='2021-01-01', suggesteddate='2021-01-01', date='2021-01-01 12:12:12'; 3 - Click 'Go' In Organize by: Status 4 - Note the suggestion looks old now 5 - Check the box, and click 'Update item types with:' -> Submit 6 - Prganize by status again 7 - No change? 8 - Check the DB: SELECT date FROM suggestions; 9 - The field is updated 10 - Apply patch 11 - Organize by status again 12 - See the 'Last updated' ate set to today Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Should the bug title be updated a bit to make the issue/solution a bit clearer? Created attachment 123179 [details] [review] Bug 28408: Add new column to the table settings config Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.03 Pushed to 20.11.x for 20.11.09 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |