Bug 28426

Summary: Terminology: Reserve should be hold
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Nicolas Hunstein <nicolas.hunstein>
Status: RESOLVED MOVED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: martin.renvoize, nicolas.hunstein
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 22160    
Attachments: Bug 28426: update "Reserve", "Lost reserve" and "Cancelled reserve"

Description Katrin Fischer 2021-05-24 10:11:34 UTC
koha-tmpl/intranet-tmpl/prog/en/includes/transfer_reasons.inc:1
%s %sManual %sStock rotation advance %sStock rotation repatriation %sReturn to home library %sReturn to holding library %sRotating collection %sReserve %sLost reserve %sCancelled reserve %sTransfer was cancelled whilst in transit %s%s %s␠

koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt:126

%s %sManual %sStock rotation advance %sStock rotation repatriation %sReturn to home library %sReturn to holding library %sRotating collection %sReserve %sLost reserve %sCancelled reserve %sTransfer was cancelled whilst in transit %s%s %s␠
Comment 1 Nicolas Hunstein 2025-01-24 13:29:35 UTC
Created attachment 177114 [details] [review]
Bug 28426: update "Reserve", "Lost reserve" and "Cancelled reserve"

updates strings "Reserve", "Lost reserve" and "Cancelled reserve" to "Hold", "Lost hold" and "Cancelled hold"

to test:
- go to koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
- check there are strings "Reserve", "Lost reserve" and "Cancelled reserve"

-apply patch
-verify there are no more strings"Reserve", "Lost reserve" and "Cancelled reserve" instead there are "Hold", "Lost hold" and "Cancelled hold"
Comment 2 Owen Leonard 2025-01-24 13:45:20 UTC
I think this is not the patch you intended to attach. It's related to self-registration.
Comment 3 Nicolas Hunstein 2025-01-27 10:28:14 UTC
Was meanwhile already fixed