Summary: | When refunding lost fees we should not include voided payments [20.11 and below] | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Fines and fees | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED WONTFIX | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | martin.renvoize, nick, testopia |
Version: | 20.11 | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29923 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: | Bug 28432: Unit Tests |
Description
Martin Renvoize (ashimema)
2021-05-24 10:56:11 UTC
Created attachment 121323 [details] [review] Bug 28432: Unit Tests This patch adds test test cases for both a Voided Payment and Voided Writeoff. These cases need special handling in the refund process. Test plan 1/ Run t/db_dependent/Koha/Items.t 2/ Prior to this commit the test should pass 3/ After this commit the test should fail 4/ The subsequent commit should make the test pass again. Pretty confident in the test.. but no idea how to resolve the actual bug..
I've tried using joins to look at the credit line status.. but for some reason that breaks all sorts..
> my $credits_offsets = Koha::Account::Offsets->search(
> {
> debit_id => $lost_charge->id,
> credit_id => { '!=' => undef }, # it is not the debit itself
> 'credit.credit_type_code' => { '!=' => 'Writeoff' },
> 'credit.status' => { '!=' => 'VOID' },
> },
> { join => 'credit' }
> );
Is this 20.05 and earlier? 20.11 does not appear to have _FixAccountForLostAndReturned? As 20.11 is no longer maintained, I am moving this to WONTFIX. |