Bug 28438

Summary: Capitalization: Various corrections
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: david, kyle, martin.renvoize, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
21.11.00,21.05.05
Circulation function:
Attachments: Bug 28438: Capitalization: Various corrections
Bug 28438: Capitalization: Various corrections
Bug 28438: (follow-up) Capitalization: Various corrections
Bug 28438: Capitalization: Various corrections
Bug 28438: (follow-up) Capitalization: Various corrections

Description Owen Leonard 2021-05-24 15:28:42 UTC
I did a search for capitalization errors in the templates and found many.
Comment 1 Owen Leonard 2021-09-17 18:50:37 UTC
Created attachment 125015 [details] [review]
Bug 28438: Capitalization: Various corrections

This patch makes capitalization corrections to many templates in the
OPAC and staff interface. A exhaustive test plan would be huge, so I
recommend examining the patch to confirm that it contains correct case
changes.

If you want to make it easier to examine changes you can try:
https://github.com/so-fancy/diff-so-fancy
Comment 2 David Nind 2021-09-18 22:00:35 UTC
Created attachment 125029 [details] [review]
Bug 28438: Capitalization: Various corrections

This patch makes capitalization corrections to many templates in the
OPAC and staff interface. A exhaustive test plan would be huge, so I
recommend examining the patch to confirm that it contains correct case
changes.

If you want to make it easier to examine changes you can try:
https://github.com/so-fancy/diff-so-fancy

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2021-09-18 22:00:40 UTC
Created attachment 125030 [details] [review]
Bug 28438: (follow-up) Capitalization: Various corrections

One mdditional correction.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2021-09-18 22:01:55 UTC
Thanks Owen - some nice tidy-ups!

Testing notes:
- Reviewed diff in browser
Comment 5 Martin Renvoize (ashimema) 2021-09-24 15:14:24 UTC
Created attachment 125261 [details] [review]
Bug 28438: Capitalization: Various corrections

This patch makes capitalization corrections to many templates in the
OPAC and staff interface. A exhaustive test plan would be huge, so I
recommend examining the patch to confirm that it contains correct case
changes.

If you want to make it easier to examine changes you can try:
https://github.com/so-fancy/diff-so-fancy

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize (ashimema) 2021-09-24 15:14:27 UTC
Created attachment 125262 [details] [review]
Bug 28438: (follow-up) Capitalization: Various corrections

One mdditional correction.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Martin Renvoize (ashimema) 2021-09-24 15:14:58 UTC
Excellent work.. scald the devs for getting them wrong in the first place (that probably includes me :( )

Passing QA
Comment 8 Jonathan Druart 2021-09-28 13:38:14 UTC
Pushed to master for 21.11, thanks to everybody involved!
Comment 9 Kyle M Hall (khall) 2021-10-08 13:22:56 UTC
Pushed to 21.05.x for 21.05.05