Summary: | Add managing librarian to transaction page (boraccount.pl) | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Staff interface | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | george, gmcharlt |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 28452: add Managed by column to boraccount.tt
Bug 28452: add Managed by column to boraccount.tt Bug 28452: Add Managed by column to boraccount.tt Bug 28452: (QA follow-up) Remove comma when staff user has on firstname |
Description
Lucas Gass (lukeg)
2021-05-25 15:25:03 UTC
Created attachment 121390 [details] [review] Bug 28452: add Managed by column to boraccount.tt To test: -Do some transactions on boraccount.tt. Payments, write-offs.. -Check the transaction tab at boraccount.tt -No info about the librian who did this action -Apply patch -Try doing some more transactions -You should now see the first and last name of the librarian who accepted the payments/did the transactions Created attachment 121391 [details] [review] Bug 28452: add Managed by column to boraccount.tt To test: -Do some transactions on boraccount.tt. Payments, write-offs.. -Check the transaction tab at boraccount.tt -No info about the librian who did this action -Apply patch -Try doing some more transactions -You should now see the first and last name of the librarian who accepted the payments/did the transactions Tested on the ByWater sandboxes. Nice enhancement. Created attachment 121568 [details] [review] Bug 28452: Add Managed by column to boraccount.tt To test: -Do some transactions on boraccount.tt. Payments, write-offs.. -Check the transaction tab at boraccount.tt -No info about the librian who did this action -Apply patch -Try doing some more transactions -You should now see the first and last name of the librarian who accepted the payments/did the transactions Signed-off-by: George Williams (NEKLS) <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 121569 [details] [review] Bug 28452: (QA follow-up) Remove comma when staff user has on firstname Also removed an old outdated comment line - there are no longer any hardcoded $ signs in the template. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Sorry Lucas, after I thought this was working, there are issues: - Have you tested with another user, not the one who did the transaction? I think using the logged in user here will always make the same name appear instead of the actual user who did the transaction. You need to access the information for the line from the database. - patron-title.inc must be used for displaying the name Confirmed, the table will always show the logged in user for ALL transactions. |