| Summary: | Register details "Older transactions" search does not include the selected day in the "To" field in date range | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Fines and fees | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, david, fridolin.somers, jonathan.druart, sally.healey, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the search and display of older transactions in the cash register so that items from today are included in the results. Previously, transactions for the current day were incorrectly not included.
|
Version(s) released in: |
22.05.00,21.11.01,21.05.08
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 13985 | ||
| Attachments: |
Bug 28481: Make 'to' date inclusive.
Bug 28481: Make 'to' date inclusive. Bug 28481: Make 'to' date inclusive. Bug 28481: (QA follow-up) Set date to 23:59:59 Bug 28481: Make 'to' date inclusive. Bug 28481: (QA follow-up) Set date to 23:59:59 Bug 28481: (RM follow-up) formatting |
||
|
Description
Kyle M Hall (khall)
2021-05-28 11:45:38 UTC
OK, I understand.. so we should do an 'inclusive' search.. i.e. set the end time to the end of the day (or add a day) Created attachment 128065 [details] [review] Bug 28481: Make 'to' date inclusive. Test Plan: 1) Sell an item 2) Cash up to make the sale historical 3) Search "Older transactions" with both dates being the current date, click "Display" to search 4) Note you get no results 5) Apply the patch 6) You should now see your transaction Created attachment 128090 [details] [review] Bug 28481: Make 'to' date inclusive. Test Plan: 1) Sell an item 2) Cash up to make the sale historical 3) Search "Older transactions" with both dates being the current date, click "Display" to search 4) Note you get no results 5) Apply the patch 6) You should now see your transaction Signed-off-by: David Nind <david@davidnind.com> Should not we set the time part to 23:59:59 instead? I think it's what we do in other parts. (In reply to Jonathan Druart from comment #4) > Should not we set the time part to 23:59:59 instead? I think it's what we do > in other parts. Seems reasonable to me... I'll add a follow-up Created attachment 128428 [details] [review] Bug 28481: Make 'to' date inclusive. Test Plan: 1) Sell an item 2) Cash up to make the sale historical 3) Search "Older transactions" with both dates being the current date, click "Display" to search 4) Note you get no results 5) Apply the patch 6) You should now see your transaction Signed-off-by: David Nind <david@davidnind.com> Created attachment 128429 [details] [review] Bug 28481: (QA follow-up) Set date to 23:59:59 This patch changes the fix from adding a day to setting the time to 23:59:59. Created attachment 128453 [details] [review] Bug 28481: Make 'to' date inclusive. Test Plan: 1) Sell an item 2) Cash up to make the sale historical 3) Search "Older transactions" with both dates being the current date, click "Display" to search 4) Note you get no results 5) Apply the patch 6) You should now see your transaction Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 128454 [details] [review] Bug 28481: (QA follow-up) Set date to 23:59:59 This patch changes the fix from adding a day to setting the time to 23:59:59. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 128640 [details] [review] Bug 28481: (RM follow-up) formatting Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.01 Pushed to 21.05.x for 21.05.08 Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |