Summary: | Club holds form broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Hold requests | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | major | ||
Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, jonathan.druart, kyle, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the libraries shown in the 'Pickup at' dropdown list when placing a club hold so that it shows all libraries, instead of just the currently logged in library.
|
|
Version(s) released in: |
21.11.00,21.05.01
|
Circulation function: | |
Bug Depends on: | 28273 | ||
Bug Blocks: | |||
Attachments: |
Bug 28496: Club holds pickup locations don't come from the API
Bug 28496: Club holds pickup locations don't come from the API Bug 28496: Club holds pickup locations don't come from the API |
Description
Tomás Cohen Arazi (tcohen)
2021-06-01 14:30:43 UTC
Created attachment 121532 [details] [review] Bug 28496: Club holds pickup locations don't come from the API This patch fixes a issue that is generated by the fact different inputs were reusing the same id. To test: 1. Have a club with some enrollments 2. Make sure you have your circ rules to allow any library be a pickup location. 3. Search for a biblio 4. Try placing a club hold => FAIL: The dropdown only has the (currently) logged in library. 5. Apply this patch 6. Repeat 3-4 => SUCCESS: The dropdown has all the options Created attachment 121553 [details] [review] Bug 28496: Club holds pickup locations don't come from the API This patch fixes a issue that is generated by the fact different inputs were reusing the same id. To test: 1. Have a club with some enrollments 2. Make sure you have your circ rules to allow any library be a pickup location. 3. Search for a biblio 4. Try placing a club hold => FAIL: The dropdown only has the (currently) logged in library. 5. Apply this patch 6. Repeat 3-4 => SUCCESS: The dropdown has all the options Signed-off-by: David Nind <david@davidnind.com> Created attachment 121566 [details] [review] Bug 28496: Club holds pickup locations don't come from the API This patch fixes a issue that is generated by the fact different inputs were reusing the same id. To test: 1. Have a club with some enrollments 2. Make sure you have your circ rules to allow any library be a pickup location. 3. Search for a biblio 4. Try placing a club hold => FAIL: The dropdown only has the (currently) logged in library. 5. Apply this patch 6. Repeat 3-4 => SUCCESS: The dropdown has all the options Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.01 |