Bug 28506

Summary: Editing purchase suggestion with no library or item type does not save edits
Product: Koha Reporter: Donna <bwsdonna>
Component: AcquisitionsAssignee: Bugs List <koha-bugs>
Status: CLOSED WORKSFORME QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low    
Version: 20.05   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Crowdfunding committed: 0
Crowdfunding contact: Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Donna 2021-06-03 00:50:36 UTC
To recreate:

1. Enter a purchase suggestion in the staff client with just a title - no library or document type
2.  Edit the purchase suggestion and add publisher or ISBN, etc and save.
3.  Notice that the changes are not saved.
4.  Edit the record to add publisher and document type and save.
5.  On the purchase suggestion summary screen, see that the item type was added, but publisher was not.
6.  Edit the purchase suggestion again and see that the document/item type does not show.  
7.  Add publisher and select a library and save.
8.  All data is updated, but the purchase suggestion gets moved to Status Unknown.
Comment 1 Katrin Fischer 2021-06-03 16:46:51 UTC
I don't manage to add a suggestion without a library in the staff interface, it always reverts the pull down to my logged in library (I think it shouldn't and feel like we had fixed that before?)

The Document type list doesn't offer an empty entry by default.

Otherwise, all changes I made to the suggestion, did save.

Donna, can you share more details on your configuration?
Comment 2 Katrin Fischer 2023-07-01 10:06:04 UTC
I've filed a new bug for the missing empty value:
Bug 34184 - "Document type" in suggestions form should have an empty entry

I cannot confirm the described behaviour on master, marking WORKSFORME. Please reopen if the problem persists.