Bug 28508

Summary: Use "Invoice number" instead of "Invoice no" on the invoice search filter
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: AcquisitionsAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Tomás Cohen Arazi <tomascohen>
Severity: enhancement    
Priority: P5 - low CC: kyle, salman.ali, tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Text to go in the release notes:
Version(s) released in:
21.11.00
Attachments: Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter
Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter
Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter

Description Aleisha Amohia 2021-06-03 02:56:29 UTC
There is not much benefit to using "no" instead of "number", and it makes it less translateable and understandable. This should be fixed in three places that I can see:

1. the search filter form
2. the results table column heading
3. when there are no results, there is text that says 'Search was:' and a label that says 'Invoice no.'
Comment 1 Owen Leonard 2021-06-09 11:11:06 UTC Comment hidden (obsolete)
Comment 2 Salman Ali 2021-06-10 15:08:54 UTC
Created attachment 121796 [details] [review]
Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter

This patch corrects instances of the abbreviated phrase "Invoice no."
from the templates, making it "Invoice number." Also corrected: An
instance of "Bookseller" is replaced with "Vendor."

To test, apply the patch and confirm that the phrase is correct in these
cases:

- Acquisitions -> Invoices: Check the "Search filters" form in the
  left-hand sidebar.
  -> View an invoice: Check the label in the form.
- Acquisitions -> Vendor -> Receive shipments: Check the table of
  invoices.
- Acquisitions -> Orders search (in the search header) -> Advanced
  search: Check the labels in the form.

Signed-off-by: Salman Ali <salman@outaouais>
Comment 3 Tomás Cohen Arazi 2021-06-14 18:25:27 UTC
Created attachment 121921 [details] [review]
Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter

This patch corrects instances of the abbreviated phrase "Invoice no."
from the templates, making it "Invoice number." Also corrected: An
instance of "Bookseller" is replaced with "Vendor."

To test, apply the patch and confirm that the phrase is correct in these
cases:

- Acquisitions -> Invoices: Check the "Search filters" form in the
  left-hand sidebar.
  -> View an invoice: Check the label in the form.
- Acquisitions -> Vendor -> Receive shipments: Check the table of
  invoices.
- Acquisitions -> Orders search (in the search header) -> Advanced
  search: Check the labels in the form.

Signed-off-by: Salman Ali <salman.ali@inLibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Note: I fixed Salman's SO line
Comment 4 Jonathan Druart 2021-06-21 12:04:17 UTC
Pushed to master for 21.11, thanks to everybody involved!
Comment 5 Kyle M Hall 2021-07-09 11:58:41 UTC
Enhancement not backported to 21.05.x