| Summary: | TinyMCE for system prefs does some automatic code clean up | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Tools | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | barbara.johnson, dcook, fridolin.somers, jonathan.druart, kyle, victor |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34463 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.03,20.11.10
|
|
| Circulation function: | |||
| Attachments: |
Bug 28525: Dont let TinyMCE do code cleanup
Bug 28525: Dont let TinyMCE do code cleanup Bug 28525: Dont let TinyMCE do code cleanup Bug 28525: Dont let TinyMCE do code cleanup |
||
|
Description
Lucas Gass (lukeg)
2021-06-07 22:12:38 UTC
Created attachment 121698 [details] [review] Bug 28525: Dont let TinyMCE do code cleanup To Test: 1. Turn on 'UseWYSIWYGinSystemPreferences' 2. Go to a system preference like 'RestrictedPageContent' 3. Try entering something like '<i class="fa fa-facebook-official" aria-hidden="true">TEST</i>' in the Source Code window 4. It gets cleaned up by the editor 5. Try something like '<a href="https://www.test.com" referrerpolicy=""no-referrer-when-downgrade">TEST</a>' 6. It's cleaned up by the editor. 7. Try something like '<link href="https://fonts.googleapis.com/css?family=Open+Sans” rel=“stylesheet">' 8. Cleaned up by editor. 9. Apply patch 10. Try step 3, 5, and 7 again. 11. It should not be changed by the editor Created attachment 123717 [details] [review] Bug 28525: Dont let TinyMCE do code cleanup To Test: 1. Turn on 'UseWYSIWYGinSystemPreferences' 2. Go to a system preference like 'RestrictedPageContent' 3. Try entering something like '<i class="fa fa-facebook-official" aria-hidden="true">TEST</i>' in the Source Code window 4. It gets cleaned up by the editor 5. Try something like '<a href="https://www.test.com" referrerpolicy=""no-referrer-when-downgrade">TEST</a>' 6. It's cleaned up by the editor. 7. Try something like '<link href="https://fonts.googleapis.com/css?family=Open+Sans” rel=“stylesheet">' 8. Cleaned up by editor. 9. Apply patch 10. Try step 3, 5, and 7 again. 11. It should not be changed by the editor Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 123919 [details] [review] Bug 28525: Dont let TinyMCE do code cleanup To Test: 1. Turn on 'UseWYSIWYGinSystemPreferences' 2. Go to a system preference like 'RestrictedPageContent' 3. Try entering something like '<i class="fa fa-facebook-official" aria-hidden="true">TEST</i>' in the Source Code window 4. It gets cleaned up by the editor 5. Try something like '<a href="https://www.test.com" referrerpolicy=""no-referrer-when-downgrade">TEST</a>' 6. It's cleaned up by the editor. 7. Try something like '<link href="https://fonts.googleapis.com/css?family=Open+Sans” rel=“stylesheet">' 8. Cleaned up by editor. 9. Apply patch 10. Try step 3, 5, and 7 again. 11. It should not be changed by the editor Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123959 [details] [review] Bug 28525: Dont let TinyMCE do code cleanup If you look at Bug 24764 and Bug 26942 we adjusted the TinyMCE for the News tool so it will not do some types of automatic code clean up. The TinyMCE editor for system preferences which can be enabled by 'UseWYSIWYGinSystemPreferences' has the same problems. We should make the configurations the same. To Test: 1. Turn on 'UseWYSIWYGinSystemPreferences' 2. Go to a system preference like 'RestrictedPageContent' 3. Try entering something like '<i class="fa fa-facebook-official" aria-hidden="true">TEST</i>' in the Source Code window 4. It gets cleaned up by the editor 5. Try something like '<a href="https://www.test.com" referrerpolicy=""no-referrer-when-downgrade">TEST</a>' 6. It's cleaned up by the editor. 7. Try something like '<link href="https://fonts.googleapis.com/css?family=Open+Sans” rel=“stylesheet">' 8. Cleaned up by editor. 9. Apply patch 10. Try step 3, 5, and 7 again. 11. It should not be changed by the editor Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.03 Pushed to 20.11.x for 20.11.10 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |