Summary: | Requesting whole field in 'itemcallnumber' system preference causes internal server error | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Cataloging | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, kyle, m.de.rooy, salman.ali, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.03,20.11.09
|
|
Attachments: |
Bug 28533: Set subfields to 'undef' if whole field request in itemcallnumebr system preference
Bug 28533: Set subfields to 'undef' if whole field request in itemcallnumebr system preference Bug 28533: Set subfields to 'undef' if whole field request in itemcallnumebr system preference Bug 28533: Fix other ocurrence |
Description
Nick Clemens (kidclamp)
2021-06-09 12:59:19 UTC
Created attachment 121738 [details] [review] Bug 28533: Set subfields to 'undef' if whole field request in itemcallnumebr system preference This patch undefines the CNsubfields variable when the whole field is requested Note that the substr returns '' when no characters are found, so we test if the string eq '' Testing 'truth' doesn't work because "0" is a valid option To test: 1 - Edit a record, add an 082 field 082 0 0 ‡aalpha‡bbeta‡0delta 2 - Set itemcallnumber system preference to 082 3 - Attempt to add/edit items 4 - ISE 5 - Apply patch, restart all the things 6 - Add/edit items - no error 7 - Confirm the itemcallnumber field is populated with "alpha beta delta" 8 - Set itemcallnumber system preference to '0820' 9 - Add/edit items 10 - Confirm itemcallnumber is populated with 'delta' Created attachment 121808 [details] [review] Bug 28533: Set subfields to 'undef' if whole field request in itemcallnumebr system preference This patch undefines the CNsubfields variable when the whole field is requested Note that the substr returns '' when no characters are found, so we test if the string eq '' Testing 'truth' doesn't work because "0" is a valid option To test: 1 - Edit a record, add an 082 field 082 0 0 ‡aalpha‡bbeta‡0delta 2 - Set itemcallnumber system preference to 082 3 - Attempt to add/edit items 4 - ISE 5 - Apply patch, restart all the things 6 - Add/edit items - no error 7 - Confirm the itemcallnumber field is populated with "alpha beta delta" 8 - Set itemcallnumber system preference to '0820' 9 - Add/edit items 10 - Confirm itemcallnumber is populated with 'delta' Signed-off-by: Salman Ali <salman@outaouais> * Signed-off-by line 'Signed-off-by: Salman Ali <salman@outaouais>' seems invalid Hmm who invented this variable name :) my $temp = GetMarcBiblio({ biblionumber => $biblionumber }); (In reply to Nick Clemens from comment #0) > Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE ]$/ at > /usr/share/perl5/MARC/Field.pm line 643. Looks like Galen has a problem too. Created attachment 122870 [details] [review] Bug 28533: Set subfields to 'undef' if whole field request in itemcallnumebr system preference This patch undefines the CNsubfields variable when the whole field is requested Note that the substr returns '' when no characters are found, so we test if the string eq '' Testing 'truth' doesn't work because "0" is a valid option To test: 1 - Edit a record, add an 082 field 082 0 0 ‡aalpha‡bbeta‡0delta 2 - Set itemcallnumber system preference to 082 3 - Attempt to add/edit items 4 - ISE 5 - Apply patch, restart all the things 6 - Add/edit items - no error 7 - Confirm the itemcallnumber field is populated with "alpha beta delta" 8 - Set itemcallnumber system preference to '0820' 9 - Add/edit items 10 - Confirm itemcallnumber is populated with 'delta' Signed-off-by: Salman Ali <salman.ali@inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Same code in C4::Items::PrepareItemrecordDisplay. It certainly needs to be adjusted too. Created attachment 123343 [details] [review] Bug 28533: Fix other ocurrence Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.03 Pushed to 20.11.x for 20.11.09 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. [Just saying... Got a conflict with this patch when rebasing bug 28533. It clearly shows that the work done is very useful: 1. the need to centralize the code and 2. have test coverage for ANY changes we are making there.] |