Bug 28566

Summary:	Rename / Relabel StoreLastBorrower
Product:	Koha	Reporter:	Andrew Fuerste-Henry <andrew>
Component:	Staff interface	Assignee:	Bugs List <koha-bugs>
Status:	NEW ---	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	gmcharlt
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:

Description Andrew Fuerste-Henry 2021-06-15 14:34:39 UTC

We've created a confusing situation with how we label previous borrower data on moredetail.pl.

The regular circ history pulled from the issues table is labeled "Last borrower" for the most recent patron to have had and returned the item and "Previous borrower" for the patron before them. This data is wholly unconnected to the StoreLastBorrower system preference.

If the StoreLastBorrower system preference is turned on, then moredetail.pl will also include data from the items_last_borrower table. This data is labeled as "Last returned by."

It is needlessly confusing that we're using the phrase "last borrower" to refer to two different bits of data. We should *either* rename the syspref *or* switch the labels on moredetail.pl. The former seems like more work to patch but less confusing for users.