Summary: | Incorrect Select2 width | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Cataloging | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | dcook, fridolin.somers, katrin.fischer, kyle, m.de.rooy, oleonard, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.02,20.11.09
|
|
Bug Depends on: | |||
Bug Blocks: | 35245 | ||
Attachments: |
Bug 28611: Fix width to 50% for additem form elements
Bug 28611: Fix width to 50% for additem form elements Bug 28611: Fix width to 50% for additem form elements Bug 28611: Fix width to 50% for additem form elements Screenshot of item form pull downs in 20.11 |
Description
Jonathan Druart
2021-06-22 09:46:06 UTC
Created attachment 122276 [details] [review] Bug 28611: Fix width to 50% for additem form elements This patch suggests to set the width of select and input to 50% With this patch applied: https://snipboard.io/rME6z3.jpg Created attachment 122390 [details] [review] Bug 28611: Fix width to 50% for additem form elements This patch suggests to set the width of select and input to 50% Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 122591 [details] [review] Bug 28611: Fix width to 50% for additem form elements This patch suggests to set the width of select and input to 50% Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 122592 [details] [review] Bug 28611: Fix width to 50% for additem form elements This patch suggests to set the width of select and input to 50% Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> We know this is not the perfect solution, but until Select2 works better, I think this will be an improvement. Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.02 It is a big visual change on items editor. I propose not to impact older versions. I understand the argument, but the visual was already changed by the newer version of select2 that made the input fields too short in many cases. I have seen library pull downs only showing like 3 letters of the branch names :( Created attachment 123590 [details] Screenshot of item form pull downs in 20.11 (In reply to Katrin Fischer from comment #10) > I understand the argument, but the visual was already changed by the newer > version of select2 that made the input fields too short in many cases. I > have seen library pull downs only showing like 3 letters of the branch names > :( To explain a bit more, it means that currently you can't figure out the library actually selected, if you have some starting with the same letters. Also the X is too close to text, so I often have it happen that when I want to open the pull down, I actually empty the field. The screenshot shows the problematic classification source, home branch and holding branch selects on current 20.11.6 Oh crap, a real ergonomic bug then. I backport. The backport on 20.11 actually fails because there is on select tag the attribute size="1". This has been removed in 21.05.x by Bug 28066. Should we keep it or remove it ? (In reply to Fridolin Somers from comment #12) > Oh crap, a real ergonomic bug then. I backport. > > The backport on 20.11 actually fails because there is on select tag the > attribute size="1". > This has been removed in 21.05.x by Bug 28066. > > Should we keep it or remove it ? I believe removing it would be ok, but leaving it in probably won't cause issues right away either. (In reply to Katrin Fischer from comment #13) > (In reply to Fridolin Somers from comment #12) > > Oh crap, a real ergonomic bug then. I backport. > > > > The backport on 20.11 actually fails because there is on select tag the > > attribute size="1". > > This has been removed in 21.05.x by Bug 28066. > > > > Should we keep it or remove it ? > > I believe removing it would be ok, but leaving it in probably won't cause > issues right away either. Ok I choose to keep it. Thanks for your help ;) Pushed to 20.11.x for 20.11.09 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. (In reply to Katrin Fischer from comment #10) > I understand the argument, but the visual was already changed by the newer > version of select2 that made the input fields too short in many cases. I > have seen library pull downs only showing like 3 letters of the branch names > :( I just saw this for the first time today and it's driving me crazy... (In reply to David Cook from comment #17) > (In reply to Katrin Fischer from comment #10) > > I understand the argument, but the visual was already changed by the newer > > version of select2 that made the input fields too short in many cases. I > > have seen library pull downs only showing like 3 letters of the branch names > > :( > > I just saw this for the first time today and it's driving me crazy... We set them to a wide width by default here, still waiting for aproper fix in the library I think. |