| Summary: | Several objects.search-based routes missing parameters | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | REST API | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.06
|
|
| Circulation function: | |||
| Bug Depends on: | 28480 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 28613: Add missing parameters to objects.search-based routes
Bug 28613: Add missing parameters to objects.search-based routes |
||
|
Description
Tomás Cohen Arazi (tcohen)
2021-06-22 11:49:43 UTC
Created attachment 122279 [details] [review] Bug 28613: Add missing parameters to objects.search-based routes The objects.search helper provides convenient ways to paginate and a 'q' filter parameter to build complex queries on this Koha::Objects-based routes. Some routes were created prior to this feature getting introduced. We need to adjust the parameters for all existing objects.search-based routes. This patch adds that. The only GET (as in list) routes that would still be missing the parameters are those about ILL, that are not objects.search based, and probably need to be rewritten. https://bugs.koha-community.org/show_bug.cgi?id=28480 Created attachment 127014 [details] [review] Bug 28613: Add missing parameters to objects.search-based routes The objects.search helper provides convenient ways to paginate and a 'q' filter parameter to build complex queries on this Koha::Objects-based routes. Some routes were created prior to this feature getting introduced. We need to adjust the parameters for all existing objects.search-based routes. This patch adds that. The only GET (as in list) routes that would still be missing the parameters are those about ILL, that are not objects.search based, and probably need to be rewritten. https://bugs.koha-community.org/show_bug.cgi?id=28480 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice one, trivial fix.. Passing QA No test? So it will happen again... Pushed to master for 21.11, thanks to everybody involved! It will be in 21.05.05 It will be in 21.05.06 |