| Summary: | Remove trailing space when logging with log4perl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, kyle, martin.renvoize, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.03,20.11.09
|
|
| Circulation function: | |||
| Attachments: |
Bug 28620: Remove trailing space when logging with log4perl
Bug 28620: Remove trailing space when logging with log4perl Bug 28620: Remove trailing space when logging with log4perl Bug 28620: Replace remaining occurrence in test |
||
|
Description
Marcel de Rooy
2021-06-23 11:51:29 UTC
Using <space>%n in the config means space newline. Created attachment 122328 [details] [review] Bug 28620: Remove trailing space when logging with log4perl Trivial change. Do sed -i -r -e'/log4perl/ s/\s%n$/%n/' on the log4perl configs. Test plan: Update your own config. Trigger some logging and check that logfile. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 122678 [details] [review] Bug 28620: Remove trailing space when logging with log4perl Trivial change. Do sed -i -r -e'/log4perl/ s/\s%n$/%n/' on the log4perl configs. Test plan: Update your own config. Trigger some logging and check that logfile. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 123174 [details] [review] Bug 28620: Remove trailing space when logging with log4perl Trivial change. Do sed -i -r -e'/log4perl/ s/\s%n$/%n/' on the log4perl configs. Test plan: Update your own config. Trigger some logging and check that logfile. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123180 [details] [review] Bug 28620: Replace remaining occurrence in test Not useful but won't hurt either. At least all our occurrences are identical now. Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.03 Pushed to 20.11.x for 20.11.09 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |