Bug 28624

Summary:	Smart::Comments not used and not installed
Product:	Koha	Reporter:	Jonathan Druart <jonathan.druart>
Component:	Architecture, internals, and plumbing	Assignee:	Jonathan Druart <jonathan.druart>
Status:	CLOSED FIXED	QA Contact:	Marcel de Rooy <m.de.rooy>
Severity:	enhancement
Priority:	P5 - low	CC:	david, kyle, m.de.rooy
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	21.11.00
Circulation function:
Attachments:	Bug 28624: Remove Smart::Comments Bug 28624: Remove Smart::Comments Bug 28624: Remove Smart::Comments Bug 28624: Remove Smart::Comments

Description Jonathan Druart 2021-06-24 07:44:10 UTC

about.pl:#use Smart::Comments '####';
admin/preferences.pl:# use Smart::Comments;
labels/spinelabel-home.pl:# use Smart::Comments;
members/printslip.pl:#use Smart::Comments;
members/update-child.pl:# use Smart::Comments;
serials/subscription-add.pl:#use Smart::Comments;

But there are no '###' in those files.

Comment 1 Jonathan Druart 2021-06-24 07:49:14 UTC

Created attachment 122357 [details] [review]
Bug 28624: Remove Smart::Comments

It's not used in those files (there is no occurrence of ###), and it's
not installed anyway (it is by koha-testing-docker however).

We should remove those lines.

Test plan:
Confirm the above

Comment 2 David Nind 2021-06-24 14:27:04 UTC

Patch no longer applies 8-(...

Looks like members/printslip.pl is already fixed.

Comment 3 Jonathan Druart 2021-07-06 08:29:27 UTC

Created attachment 122602 [details] [review]
Bug 28624: Remove Smart::Comments

It's not used in those files (there is no occurrence of ###), and it's
not installed anyway (it is by koha-testing-docker however).

We should remove those lines.

Test plan:
Confirm the above

Comment 4 David Nind 2021-07-09 13:13:43 UTC

Created attachment 122742 [details] [review]
Bug 28624: Remove Smart::Comments

It's not used in those files (there is no occurrence of ###), and it's
not installed anyway (it is by koha-testing-docker however).

We should remove those lines.

Test plan:
Confirm the above

Signed-off-by: David Nind <david@davidnind.com>

Comment 5 Marcel de Rooy 2021-07-16 06:43:21 UTC

Created attachment 122868 [details] [review]
Bug 28624: Remove Smart::Comments

It's not used in those files (there is no occurrence of ###), and it's
not installed anyway (it is by koha-testing-docker however).

We should remove those lines.

Test plan:
Confirm the above

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 6 Jonathan Druart 2021-07-26 10:48:11 UTC

Pushed to master for 21.11, thanks to everybody involved!

Comment 7 Kyle M Hall (khall) 2021-07-30 15:12:38 UTC

Enhancement not backported for 21.05