Description
Andrew Isherwood
2021-06-30 14:34:39 UTC
+1 Created attachment 146023 [details] [review] Bug 28641: ILLHiddenRequestStatuses does not consider custom statuses This patch adds the status_alias column to the ILLHiddenRequestStatuses sys pref check. Because requests will have status_alias NULL by default, we also check for that. Test plan: Create multiple ILL requests of different backends and place them in different status (NEW, COMP, REQ, etc) Create multiple ILLSTATUS entries Add and remove a mix of both status and status_alias codes in ILLHiddenRequestStatuses and refresh the ILL requests page to confirm the result is according to expectation. Created attachment 146522 [details] [review] Bug 28641: ILLHiddenRequestStatuses does not consider custom statuses This patch adds the status_alias column to the ILLHiddenRequestStatuses sys pref check. Because requests will have status_alias NULL by default, we also check for that. Test plan: Create multiple ILL requests of different backends and place them in different status (NEW, COMP, REQ, etc) Create multiple ILLSTATUS entries Add and remove a mix of both status and status_alias codes in ILLHiddenRequestStatuses and refresh the ILL requests page to confirm the result is according to expectation. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 148334 [details] [review] Bug 28641: ILLHiddenRequestStatuses does not consider custom statuses This patch adds the status_alias column to the ILLHiddenRequestStatuses sys pref check. Because requests will have status_alias NULL by default, we also check for that. Test plan: Create multiple ILL requests of different backends and place them in different status (NEW, COMP, REQ, etc) Create multiple ILLSTATUS entries Add and remove a mix of both status and status_alias codes in ILLHiddenRequestStatuses and refresh the ILL requests page to confirm the result is according to expectation. Sponsored-by: PTFS Europe Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Added sponsored-by line. Patch still applies. Created attachment 148852 [details] [review] Bug 28641: ILLHiddenRequestStatuses does not consider custom statuses This patch adds the status_alias column to the ILLHiddenRequestStatuses sys pref check. Because requests will have status_alias NULL by default, we also check for that. Test plan: Create multiple ILL requests of different backends and place them in different status (NEW, COMP, REQ, etc) Create multiple ILLSTATUS entries Add and remove a mix of both status and status_alias codes in ILLHiddenRequestStatuses and refresh the ILL requests page to confirm the result is according to expectation. Sponsored-by: PTFS Europe Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Shouldn't we rename this 'alias' into a 'tag' or similar instead, and stop treating them as aliases? (In reply to Tomás Cohen Arazi from comment #7) > Shouldn't we rename this 'alias' into a 'tag' or similar instead, and stop > treating them as aliases? Any other word for 'alias' could work, but I think we should first understand the problem that status_alias is trying to solve in the first place. In reality, status_alias is just an alternate status text to show in the UI for its respective request that can be filtered and searched on. Example: A request with status (code, name) of "COMP, Completed", that has the status_alias AV (code, description) of "COMP_RET, Item returned", will show "Item returned" in the status column in the ILL list datatable. So, this feature is really just adding the possibility for the Staff user to change the visible status text of any given request, without actually changing the request status in the database and regardless of the statuses that the request backend provides in the status_graph. We may want to rethink how we implement this feature, I don't know if just changing alias to a different word is enough, but I don't have any better suggestions right now. Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Backported to 22.05.x for upcoming 22.05.12 applied to 21.11.x for 21.11.20 |