| Summary: | With SearchMyLibraryFirst: If library isn't set for the OPAC, try to guess it by checking branchip | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Michael Hafen <michael.hafen> |
| Component: | OPAC | Assignee: | Michael Hafen <michael.hafen> |
| Status: | BLOCKED --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bugzilla, kyle, Laura.escamilla, lucas, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 28657 | ||
| Bug Blocks: | |||
| Attachments: |
Proposed patch
Bug 28658 - With SearchMyLibraryFirst guess the opac clients library |
||
|
Description
Michael Hafen
2021-07-02 17:09:30 UTC
Created attachment 122573 [details] [review] Proposed patch Is this ready for testing? If so please set the status to "Needs Signoff." Hi Micheal, The dependency for this bug, Bug 28657, no longer applies cleanly to master. Therefore I am going to set this one to blocked until 28657 is rebased. Bug 28657 has been rebased. Test plan: 1. Turn on SearchMyLibraryFirst system preference. 2. Make sure your computers ip address is covered by a branch's branchip. 3. Go to opac. 4. Observe that the branch isn't set. 5. Apply patch. Restart things if necessary 6. Reload opac. 7. Observe that the branch is set. Hi Michael, The dependency bug, Bug 28657, still does not apply cleanly to master. Auto-merging C4/Auth.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 28657: expand branches.branchip to allow for multiple ip ranges. [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-28657-expand-branchesbranchip-to-allow-for-mul-gxoeH0.patch Cannot apply cleanly patches from bug 28657. Everything will be left dirty. I'm going to mark this bug as blocked again. Created attachment 149432 [details] [review] Bug 28658 - With SearchMyLibraryFirst guess the opac clients library If the SearchMyLibraryFirst syspref is set, the OPAC uses the logged in users branchcode to limit searches to their library. If it's an anonymous session that doesn't happen. This tries to guess the client library by checking for the client ip address in each libraries branchip setting. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Setting to Blocked. Dependency is in FQA Setting back to Signed Off. Dependency is back to Needs signoff. This is currently BLOCKED - we need a sign-off on the dependency first. |