Summary: | Not possible to log out of patron account in OPAC with JavaScript disabled | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.03
|
|
Circulation function: | |||
Bug Depends on: | 27445 | ||
Bug Blocks: | |||
Attachments: |
Bug 28662: Not possible to log out of patron account in OPAC with JavaScript disabled
Bug 28662: Not possible to log out of patron account in OPAC with JavaScript disabled Bug 28662: Not possible to log out of patron account in OPAC with JavaScript disabled |
Description
Katrin Fischer
2021-07-03 21:01:34 UTC
Created attachment 122619 [details] [review] Bug 28662: Not possible to log out of patron account in OPAC with JavaScript disabled This patch adds a "Log out" link to the OPAC header which is hidden by CSS when JavaScript is enabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log in to the OPAC with JavaScript disabled in your browser. - In the header next to the logged-in user's name there should be a "Log out." link. - Confirm that it logs the user out. - Enable JavaScript and repeat the process to confirm that the new logout link doesn't appear. Created attachment 122756 [details] [review] Bug 28662: Not possible to log out of patron account in OPAC with JavaScript disabled This patch adds a "Log out" link to the OPAC header which is hidden by CSS when JavaScript is enabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log in to the OPAC with JavaScript disabled in your browser. - In the header next to the logged-in user's name there should be a "Log out." link. - Confirm that it logs the user out. - Enable JavaScript and repeat the process to confirm that the new logout link doesn't appear. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> (In reply to Katrin Fischer from comment #0) > While testing the patches from bug 27445 I noticed that there is no log out > option visible when using the OPAC with Javascript disabled. Since so much functionality depends on javascript/jquery, I am wondering if we still should take care of these things? Surely, logging out is very fundamental. But more in general? Created attachment 122867 [details] [review] Bug 28662: Not possible to log out of patron account in OPAC with JavaScript disabled This patch adds a "Log out" link to the OPAC header which is hidden by CSS when JavaScript is enabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log in to the OPAC with JavaScript disabled in your browser. - In the header next to the logged-in user's name there should be a "Log out." link. - Confirm that it logs the user out. - Enable JavaScript and repeat the process to confirm that the new logout link doesn't appear. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Marcel de Rooy from comment #3) > Since so much functionality depends on javascript/jquery, I am wondering if > we still should take care of these things? Surely, logging out is very > fundamental. But more in general? We have always tried to provide a usable experience to users of the OPAC without JavaScript. I think it's time to re-evaluate that choice, but we should probably begin that process in a dev meeting. Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.03 |