Summary: | Locale::XGettext::TT2 shows as missing in about.pl page | ||
---|---|---|---|
Product: | Koha | Reporter: | Mason James <mtj> |
Component: | Packaging | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy, mtj, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29642 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30252 |
||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | pic |
Shouldn't we search for Locale::XGettext instead? libtemplate-plugin-gettext-perl is bringing * /usr/share/perl5/Locale/XGettext/TT2.pm * /usr/share/perl5/Template/Plugin/Gettext.pm Locale::XGettext::TT does not have a specific version (either a bug or it's supposed to return the Locale::XGettext version?) /usr/share/perl5/Locale/XGettext.pm is installed via liblocale-xgettext-perl But Locale::XGettex is missing from cpanfile. Not sure what to do here. diff --git a/cpanfile b/cpanfile index 6e13f049320..70dd516d449 100644 --- a/cpanfile +++ b/cpanfile @@ -144,7 +144,7 @@ recommends 'Gravatar::URL', '1.03'; recommends 'HTTPD::Bench::ApacheBench', '0.73'; recommends 'LWP::Protocol::https', '5.836'; recommends 'Lingua::Ispell', '0.07'; -recommends 'Locale::XGettext::TT2', '0.7'; +recommends 'Locale::XGettext', '0.7'; recommends 'Module::Bundled::Files', '0.03'; recommends 'Module::Load::Conditional', '0.38'; recommends 'Module::Pluggable', '3.9'; It makes it looks ok but feels wrong. (In reply to Jonathan Druart from comment #2) > diff --git a/cpanfile b/cpanfile > index 6e13f049320..70dd516d449 100644 > --- a/cpanfile > +++ b/cpanfile > @@ -144,7 +144,7 @@ recommends 'Gravatar::URL', '1.03'; > recommends 'HTTPD::Bench::ApacheBench', '0.73'; > recommends 'LWP::Protocol::https', '5.836'; > recommends 'Lingua::Ispell', '0.07'; > -recommends 'Locale::XGettext::TT2', '0.7'; > +recommends 'Locale::XGettext', '0.7'; > recommends 'Module::Bundled::Files', '0.03'; > recommends 'Module::Load::Conditional', '0.38'; > recommends 'Module::Pluggable', '3.9'; > > > It makes it looks ok but feels wrong. If TT2 is part of the library distribution, it is ok imho. (In reply to Tomás Cohen Arazi from comment #3) > (In reply to Jonathan Druart from comment #2) > > diff --git a/cpanfile b/cpanfile > > index 6e13f049320..70dd516d449 100644 > > --- a/cpanfile > > +++ b/cpanfile > > @@ -144,7 +144,7 @@ recommends 'Gravatar::URL', '1.03'; > > recommends 'HTTPD::Bench::ApacheBench', '0.73'; > > recommends 'LWP::Protocol::https', '5.836'; > > recommends 'Lingua::Ispell', '0.07'; > > -recommends 'Locale::XGettext::TT2', '0.7'; > > +recommends 'Locale::XGettext', '0.7'; > > recommends 'Module::Bundled::Files', '0.03'; > > recommends 'Module::Load::Conditional', '0.38'; > > recommends 'Module::Pluggable', '3.9'; > > > > > > It makes it looks ok but feels wrong. > > If TT2 is part of the library distribution, it is ok imho. See comment 2, Locale::XGettext::TT2 is brought by libtemplate-plugin-gettext-perl, not liblocale-xgettext-perl. (In reply to Mason James from comment #5) > fixed in bug 30252 closing :0) (In reply to Mason James from comment #5) > fixed in bug 30252 Added a comment there. Not sure if completely fixed.. |
Created attachment 122597 [details] pic the Locale::XGettext::TT2 perl module is installed via the debian libtemplate-plugin-gettext-perl package, but still shows as uninstalled in about.pl # dpkg -L libtemplate-plugin-gettext-perl | grep -i tt2 /usr/bin/xgettext-tt2 /usr/share/man/man1/xgettext-tt2.1p.gz /usr/share/man/man3/Locale::XGettext::TT2.3pm.gz /usr/share/perl5/Locale/XGettext/TT2.pm /usr/share/perl5/Locale/XGettext/TT2.pod