Summary: | Improve EDI debug logging | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Architecture, internals, and plumbing | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | normal | ||
Priority: | P5 - low | CC: | arthur.suzuki, kyle, lucas, olivier.hubert, pedro.amorim, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03,22.05.10,21.11.18
|
|
Circulation function: | |||
Attachments: |
Bug 28672: Pass itemnumber instead of item object
Bug 28672: Pass itemnumber instead of item object Bug 28672: (QA follow-up) Method calls cannot be interpolated directly Bug 28672: (QA follow-up) Method calls cannot be interpolated directly |
Description
Martin Renvoize (ashimema)
2021-07-07 11:39:19 UTC
Created attachment 122648 [details] [review] Bug 28672: Pass itemnumber instead of item object The warn call here was passing the full item object which leads to HASH() in the logs.. this patch updates it to pass the itemnumber which is more helpful. The patch applies but I am unsure of how to proceed in order to confirm that this works as intended. Can you provide a test plan? Created attachment 145931 [details] [review] Bug 28672: Pass itemnumber instead of item object The warn call here was passing the full item object which leads to HASH() in the logs.. this patch updates it to pass the itemnumber which is more helpful. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 145932 [details] [review] Bug 28672: (QA follow-up) Method calls cannot be interpolated directly Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 145933 [details] [review] Bug 28672: (QA follow-up) Method calls cannot be interpolated directly Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> (In reply to Olivier Hubert from comment #2) > The patch applies but I am unsure of how to proceed in order to confirm that > this works as intended. Can you provide a test plan? Testing this patch requires importing an EDI invoice with a partially received quantity. This is trivial and hard to test so I am passing qa directly. Thanks for tackling this one Kyle, and thanks for the follow-up.. just reading it this morning I thought we probably needed that. Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to 22.11.x for next release Technically an enhancement. However, better logging is always good so I choose to backport. Backported to 22.05.x for upcoming 22.05.10 same as lucas, applied to 21.11.x for 21.11.18 Not backported to 21.05.x |