Bug 28674

Summary: old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold"
Product: Koha Reporter: Henry Bolshaw <bolshawh>
Component: DatabaseAssignee: Katrin Fischer <katrin.fischer>
Status: RESOLVED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: trivial    
Priority: P5 - low CC: jacob.omara, jonathan.druart, martin.renvoize
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03
Attachments: Bug 28674: Fix typo 'hlpd' in schema comments
Bug 28674: Fix typo 'hlpd' in schema comments
Bug 28674: Fix typo 'hlpd' in schema comments

Description Henry Bolshaw 2021-07-07 13:30:55 UTC
The reserves and old_reserves table schemas have typos in the comments for the item_level_hold field.

The comments say "Is the hpld placed at item level" but it should be "Is the hold placed at item level".

The typo is in the 21.05, 20.11, 20.05 and 19.11 versions.

http://schema.koha-community.org/21_05/tables/reserves.html

http://schema.koha-community.org/21_05/tables/old_reserves.html
Comment 1 Katrin Fischer 2023-02-04 23:21:54 UTC
Created attachment 146176 [details] [review]
Bug 28674: Fix typo 'hlpd' in schema comments

Fixes the lines for old_reserves.item_level_hold and
reserves.item_level_hold comments to read 'hold'
instead of 'hpld'

To test:
* The easiest way to verify this change is by looking
at the patch itself
Comment 2 Owen Leonard 2023-02-06 13:36:15 UTC
Created attachment 146268 [details] [review]
Bug 28674: Fix typo 'hlpd' in schema comments

Fixes the lines for old_reserves.item_level_hold and
reserves.item_level_hold comments to read 'hold'
instead of 'hpld'

To test:
* The easiest way to verify this change is by looking
at the patch itself

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize 2023-02-07 13:18:46 UTC
Created attachment 146325 [details] [review]
Bug 28674: Fix typo 'hlpd' in schema comments

Fixes the lines for old_reserves.item_level_hold and
reserves.item_level_hold comments to read 'hold'
instead of 'hpld'

To test:
* The easiest way to verify this change is by looking
at the patch itself

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Tomás Cohen Arazi 2023-02-07 13:50:13 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-02-08 16:37:28 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 6 Jacob O'Mara 2023-02-13 09:45:44 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.