Bug 28677

Summary: Add the word "calendar" to the description for ExpireReservesOnHolidays
Product: Koha Reporter: Andrew Fuerste-Henry <andrewfh>
Component: Staff interfaceAssignee: Andrew Fuerste-Henry <andrewfh>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, kyle, lucy.vaux-harvey
Version: masterKeywords: Manual-updated
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
21.11.00
Attachments: Bug 28677: Update wording on ExpireReservesOnHolidays
Bug 28677: Update wording on ExpireReservesOnHolidays
Bug 28677: Update wording on ExpireReservesOnHolidays
Bug 28677: (QA follow-up) Correct capitalization

Description Andrew Fuerste-Henry 2021-07-07 15:33:22 UTC
In a previous bug, we standardized wording of several calendar-related sysprefs so they'd be easy to find in a single search. We should have included ExcludeHolidaysFromMaxPickupDelay in that.
Comment 1 Andrew Fuerste-Henry 2021-07-08 14:40:03 UTC
Highlighting some of the issue around these, I filed this bug with the wrong syspref in the name. This is actually about ExpireReservesOnHolidays.

Right now it reads:
(Allow / Don't allow) expired holds to be canceled on days the library is closed.
Comment 2 Andrew Fuerste-Henry 2021-07-19 16:36:40 UTC
Created attachment 122956 [details] [review]
Bug 28677: Update wording on ExpireReservesOnHolidays

To test:
1: look at ExpireReservesOnHolidays syspref description
2: apply patch, restart
3: look at wording again, see that it now clarifies that it only pertains to systems using ExpireReservesMaxPickUpDelay and includes the word "calendar"
Comment 3 Owen Leonard 2021-07-20 10:44:43 UTC
Created attachment 122960 [details] [review]
Bug 28677: Update wording on ExpireReservesOnHolidays

To test:
1: look at ExpireReservesOnHolidays syspref description
2: apply patch, restart
3: look at wording again, see that it now clarifies that it only pertains to systems using ExpireReservesMaxPickUpDelay and includes the word "calendar"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Katrin Fischer 2021-07-24 22:55:59 UTC
Created attachment 123161 [details] [review]
Bug 28677: Update wording on ExpireReservesOnHolidays

To test:
1: look at ExpireReservesOnHolidays syspref description
2: apply patch, restart
3: look at wording again, see that it now clarifies that it only pertains to systems using ExpireReservesMaxPickUpDelay and includes the word "calendar"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2021-07-24 22:56:04 UTC
Created attachment 123162 [details] [review]
Bug 28677: (QA follow-up) Correct capitalization

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Jonathan Druart 2021-07-26 10:48:22 UTC
Pushed to master for 21.11, thanks to everybody involved!
Comment 7 Kyle M Hall 2021-07-30 15:04:51 UTC
Enhancement not backported to 21.05