Summary: | Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled | ||
---|---|---|---|
Product: | Koha | Reporter: | Chad Billman <chad> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | major | ||
Priority: | P5 - low | CC: | david, dcook, fridolin.somers, jonathan.druart, kyle, mtompset, oleonard, tomascohen, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the login link in the OPAC when GoogleOpenIDConnect is enabled. It removes modal-related markup which was causing the link to fail.
|
|
Version(s) released in: |
21.11.00,21.05.03,20.11.09
|
Circulation function: | |
Bug Depends on: | 20168 | ||
Bug Blocks: | |||
Attachments: |
Bug 28679: Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled
Bug 28679: Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled Bug 28679: Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled |
Description
Chad Billman
2021-07-07 18:34:17 UTC
Caused by ? commit 9cb89b46397efc5e288723829613c33e7eea0d69 Bug 20168: Update of the OPAC bootstrap template to bootstrap v4 Created attachment 122780 [details] [review] Bug 28679: Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled This patch corrects the login link in the OPAC when GoogleOpenIDConnect is enabled. It removes modal-related markup which was causing the link to fail. To test, apply the patch and enable the GoogleOpenIDConnect system preference. - In the OPAC, click the "Log in to your account" link in the header. You should be redirected to a Google authentication form. - Disable the GoogleOpenIDConnect preference. The login link in the OPAC should trigger a modal login form. Created attachment 122928 [details] [review] Bug 28679: Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled This patch corrects the login link in the OPAC when GoogleOpenIDConnect is enabled. It removes modal-related markup which was causing the link to fail. To test, apply the patch and enable the GoogleOpenIDConnect system preference. - In the OPAC, click the "Log in to your account" link in the header. You should be redirected to a Google authentication form. - Disable the GoogleOpenIDConnect preference. The login link in the OPAC should trigger a modal login form. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 123159 [details] [review] Bug 28679: Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled This patch corrects the login link in the OPAC when GoogleOpenIDConnect is enabled. It removes modal-related markup which was causing the link to fail. To test, apply the patch and enable the GoogleOpenIDConnect system preference. - In the OPAC, click the "Log in to your account" link in the header. You should be redirected to a Google authentication form. - Disable the GoogleOpenIDConnect preference. The login link in the OPAC should trigger a modal login form. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> The solution was also confirmed on the mailing list. Pushed to master for 21.11, thanks to everybody involved! Is it possible to get this merged into 21.05 as well? (In reply to Chad Billman from comment #7) > Is it possible to get this merged into 21.05 as well? This is marked as a "major" bug fix so chances are good, especially if you can confirm that the problem exists in 21.05 as well. The workflow is so that after this being pushed to master (what will be 21.11), the RMaint of the next lower version will check if it is needed and then so on. RMaints always have the final decision for their version. I can confirm this bug is impacting our 21.05.01 installation. Pushed to 21.05.x for 21.05.03 Pushed to 20.11.x for 20.11.09 Missing dependencies for 20.05.x, it shouldn't be affected, no backport. I'm thankful this is already pushed, but I'm curious why was the role attribute removed as well? It was only the data-modal part that was preventing it. (In reply to Mark Tompsett from comment #13) > I'm curious why was the role > attribute removed as well? When GoogleOpenIDConnect is enabled the link is a real link, not a trigger for something. "clickable elements that trigger a response when activated by the user." -- https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/button_role. |