| Summary: | Record detail page fails if error with search for analytics | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Searching | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | didier.gautheron, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29284 |
||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 28513 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 28682: Protect search for analytics in record detail page
Bug 28682: Protect search for analytics in record detail page |
||
|
Description
Fridolin Somers
2021-07-08 01:41:27 UTC
Created attachment 122661 [details] [review] Bug 28682: Protect search for analytics in record detail page In record detail page, there is a search for analytics, see Bug 15851. If for any reason this search fails, the page will be broken with 'Internal server error'. This patch adds a protection with eval. Test plan : 1) Use a Zebra install with no Elasticsearch configuration 2) Go to staff interface 3) Go to any record detail page : no error 4) Change preference 'SearchEngine' to 'Elasticsearch' 5) Refresh ecord detail page : check you have no error 6) Check a record with analytics link 7) Repeat 3 to 6 on OPAC The one case reported to me (Koha 20.11 with ES) is a title : Viva la revolution ! I don't know why analytics search fails but it should not block the page. And in UNIMARC seems analytics search is not used. 28513 (edit) (In reply to Fridolin Somers from comment #2) > The one case reported to me (Koha 20.11 with ES) is a title : Viva la > revolution ! > > I don't know why analytics search fails but it should not block the page. > And in UNIMARC seems analytics search is not used. And fails even with apply of Bug 28513 :( Missing a ; in opac/opac-detail.pl compilation error: Could not compile /home/koha/src/opac/opac-detail.pl: syntax error at /home/koha/src/opac/opac-detail.pl line 199, near "my " Oupsy :) Created attachment 123800 [details] [review] Bug 28682: Protect search for analytics in record detail page In record detail page, there is a search for analytics, see Bug 15851. If for any reason this search fails, the page will be broken with 'Internal server error'. This patch adds a protection with eval. Test plan : 1) Use a Zebra install with no Elasticsearch configuration 2) Go to staff interface 3) Go to any record detail page : no error 4) Change preference 'SearchEngine' to 'Elasticsearch' 5) Refresh ecord detail page : check you have no error 6) Check a record with analytics link 7) Repeat 3 to 6 on OPAC I rise to major because it can block one of the most important page, and impact OPAC I'm not so sure about this.. bug 28316 and bug 28484 resolve at a lower level by cleaning the search query so you yield the right results rather than hiding any results. (In reply to Martin Renvoize from comment #8) > I'm not so sure about this.. bug 28316 and bug 28484 resolve at a lower > level by cleaning the search query so you yield the right results rather > than hiding any results. OK maybe we just keep this fix for versions < 21.11. *** This bug has been marked as a duplicate of bug 29284 *** Nice adds a similar patch, but I prefer his scope and output so I'll QA that one in preference.. Marking as duplicate. |