Summary: | Library MARCOrgCode field needs maxlength attribute | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, kyle, nick, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes an error that occurs when you enter a "MARC organization code" in the form for adding and editing libraries. With this change the input field is limited to 16 characters.
|
Version(s) released in: |
21.11.00,21.05.03,20.11.09
|
Circulation function: | |||
Attachments: |
Bug 28704: Library MARCOrgCode field needs maxlength attribute
Bug 28704: Library MARCOrgCode field needs maxlength attribute Bug 28704: Library MARCOrgCode field needs maxlength attribute |
Description
Owen Leonard
2021-07-13 10:54:37 UTC
Created attachment 122800 [details] [review] Bug 28704: Library MARCOrgCode field needs maxlength attribute This patch adds a maxlength attribute to the "MARC organization code" field in the form for adding and editing libraries. The maxlength, 16, matches the limit of the table column. To reproduce the problem, go to Administration -> Libraries. - Add or edit a library - Fill the "MARC organization code" field with a string longer than 16 characters, e.g. Decriminalization - When you save the record you will see an error. Apply the patch and add or edit a library. - Confirm that you cannot enter more than 16 characters in the "MARC organization code" field. Created attachment 123288 [details] [review] Bug 28704: Library MARCOrgCode field needs maxlength attribute This patch adds a maxlength attribute to the "MARC organization code" field in the form for adding and editing libraries. The maxlength, 16, matches the limit of the table column. To reproduce the problem, go to Administration -> Libraries. - Add or edit a library - Fill the "MARC organization code" field with a string longer than 16 characters, e.g. Decriminalization - When you save the record you will see an error. Apply the patch and add or edit a library. - Confirm that you cannot enter more than 16 characters in the "MARC organization code" field. Signed-off-by: David Nind <david@davidnind.com> Created attachment 123298 [details] [review] Bug 28704: Library MARCOrgCode field needs maxlength attribute This patch adds a maxlength attribute to the "MARC organization code" field in the form for adding and editing libraries. The maxlength, 16, matches the limit of the table column. To reproduce the problem, go to Administration -> Libraries. - Add or edit a library - Fill the "MARC organization code" field with a string longer than 16 characters, e.g. Decriminalization - When you save the record you will see an error. Apply the patch and add or edit a library. - Confirm that you cannot enter more than 16 characters in the "MARC organization code" field. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.03 Pushed to 20.11.x for 20.11.09 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |