Summary: | "Edit item" button on moredetail should be enabled with edit_items permission | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | Cataloging | Assignee: | Andrew Fuerste-Henry <andrew> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, m.de.rooy, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.03,20.11.09
|
|
Circulation function: | |||
Attachments: |
Bug 28727: Show edit item link when user has edit items permission
Bug 28727: Show edit item link when user has edit items permission Bug 28727: Show edit item link when user has edit items permission Bug 28727: (QA follow-up) Simplify permission check |
Description
Andrew Fuerste-Henry
2021-07-20 19:31:55 UTC
Created attachment 122992 [details] [review] Bug 28727: Show edit item link when user has edit items permission To test: 1: log in as a user with edit_items but not edit_catalogue 2: confirm you do not get an Edit Item link on moredetail.pl 3: apply patch, restart, reload 4: confirm link now shows Created attachment 123209 [details] [review] Bug 28727: Show edit item link when user has edit items permission To test: 1: log in as a user with edit_items but not edit_catalogue 2: confirm you do not get an Edit Item link on moredetail.pl 3: apply patch, restart, reload 4: confirm link now shows Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 123726 [details] [review] Bug 28727: Show edit item link when user has edit items permission To test: 1: log in as a user with edit_items but not edit_catalogue 2: confirm you do not get an Edit Item link on moredetail.pl 3: apply patch, restart, reload 4: confirm link now shows Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123727 [details] [review] Bug 28727: (QA follow-up) Simplify permission check There was another permission check for edit_items directly below, so instead of changing them to both be edit_items, I think we can now remove one. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.03 Another funny behavior. With only edit_items you have access and links to "Cataloguing" home page, but its empty. It is for another bug report. Pushed to 20.11.x for 20.11.09 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |