Summary: | Holds ratio page links to itself pointlessly | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | Staff interface | Assignee: | Andrew Fuerste-Henry <andrew> |
Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, nick, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.11.00,21.05.03,20.11.09
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 29279 | ||
Attachments: |
Bug 28728: Link to holds page from holds raio
Bug 28728: Link to holds page from holds raio Bug 28728: Link to holds page from holds raio |
Description
Andrew Fuerste-Henry
2021-07-21 11:45:50 UTC
Created attachment 123011 [details] [review] Bug 28728: Link to holds page from holds raio To test: 1 - Find a bib with 1 item, place 3 bib-level holds on it (just to make sure there's at least one title on your holds ratio page) 2 - Go to the holds ratio page in circulation 3 - mouse over the Holds Ratio column, see that the number there is a link to http://[your koha]/cgi-bin/koha/circ/reserveratios.pl#, the page you're already on 4 - apply patch, restart_all, reload page 5 - link now goes to the holds page for that title Turns out that link was doing something -- clicking it changed the ratio value for your search to the ratio for the title in question. I really don't see the utility in that, so I removed it and replaced it with a link to the title's holds page. Please let me know if the old behavior needs to be retained, but I suspect it does not. Created attachment 123096 [details] [review] Bug 28728: Link to holds page from holds raio To test: 1 - Find a bib with 1 item, place 3 bib-level holds on it (just to make sure there's at least one title on your holds ratio page) 2 - Go to the holds ratio page in circulation 3 - mouse over the Holds Ratio column, see that the number there is a link to http://[your koha]/cgi-bin/koha/circ/reserveratios.pl#, the page you're already on 4 - apply patch, restart_all, reload page 5 - link now goes to the holds page for that title Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 123103 [details] [review] Bug 28728: Link to holds page from holds raio To test: 1 - Find a bib with 1 item, place 3 bib-level holds on it (just to make sure there's at least one title on your holds ratio page) 2 - Go to the holds ratio page in circulation 3 - mouse over the Holds Ratio column, see that the number there is a link to http://[your koha]/cgi-bin/koha/circ/reserveratios.pl#, the page you're already on 4 - apply patch, restart_all, reload page 5 - link now goes to the holds page for that title Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> (In reply to Andrew Fuerste-Henry from comment #2) > Turns out that link was doing something -- clicking it changed the ratio > value for your search to the ratio for the title in question. I really don't > see the utility in that, so I removed it and replaced it with a link to the > title's holds page. Please let me know if the old behavior needs to be > retained, but I suspect it does not. How do we know it's actually not used? Did you ask around you? (In reply to Jonathan Druart from comment #5) > How do we know it's actually not used? Did you ask around you? I haven't asked around beyond showing this bug to a few people, but I've found no documentation or discussion of the behavior and, frankly, it doesn't really *do* much. I'd hate for this to stall out due to the difficulty of demonstrating that the current link isn't used. I think the updated behavior is much more user-friendly, not to mention actually useful. I think it's more relevant to the use of the report to be able to click directly to the holds list than it is to click to type a number. Pushed to master for 21.11, thanks to everybody involved! (In reply to Jonathan Druart from comment #8) > Pushed to master for 21.11, thanks to everybody involved! Thanks! I see it has been pushed to 21.05.x for 21.05.03 Pushed to 20.11.x for 20.11.09 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. For what it's worth, the bit about clicking the ratio to populate the form field dates back to 2009 in commit de38cf6df from bug 3130. However, _why_ this was done is currently lost to the mists of time. |