Summary: | Batch item modifications no longer displayed modified items | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.03
|
|
Circulation function: | |||
Bug Depends on: | 28158 | ||
Bug Blocks: | |||
Attachments: |
Bug 28745: (bug 28158 follow-up) Restore the items table once the job is done
Bug 28745: (bug 28158 follow-up) Restore the items table once the job is done Bug 28745: (bug 28158 follow-up) Restore the items table once the job is done |
Description
Jonathan Druart
2021-07-23 09:48:54 UTC
Created attachment 123094 [details] [review] Bug 28745: (bug 28158 follow-up) Restore the items table once the job is done Caused by bug 28158, the batch item modifications tool does not longer display the table with the items that have been modified on the result screen. There is no more fork and so no more completedJobID var. We must process the items THEN build the items' info. Test plan: Use the batch item modification tools to modify some items. Confirm that with this patch the table with the modified items is displayed on the last screen. QA: Don't be afraid by the size of the size, it's only a swap of the code. Created attachment 123095 [details] [review] Bug 28745: (bug 28158 follow-up) Restore the items table once the job is done Caused by bug 28158, the batch item modifications tool does not longer display the table with the items that have been modified on the result screen. There is no more fork and so no more completedJobID var. We must process the items THEN build the items' info. Test plan: Use the batch item modification tools to modify some items. Confirm that with this patch the table with the modified items is displayed on the last screen. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 123098 [details] [review] Bug 28745: (bug 28158 follow-up) Restore the items table once the job is done Caused by bug 28158, the batch item modifications tool does not longer display the table with the items that have been modified on the result screen. There is no more fork and so no more completedJobID var. We must process the items THEN build the items' info. Test plan: Use the batch item modification tools to modify some items. Confirm that with this patch the table with the modified items is displayed on the last screen. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.03 |