Bug 28765

Summary: sub find_value not used in tools/batchMod.pl
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: martin.renvoize
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
21.11.00
Bug Depends on:    
Bug Blocks: 28445    
Attachments: Bug 28765: Remove sub find_value from batchMod.pl
Bug 28765: Remove sub find_value from batchMod.pl
Bug 28765: Remove sub find_value from batchMod.pl

Description Jonathan Druart 2021-07-27 12:54:51 UTC
This subroutine is not used and can be removed
Comment 1 Jonathan Druart 2021-07-27 12:56:28 UTC
Created attachment 123211 [details] [review]
Bug 28765: Remove sub find_value from batchMod.pl

It has never been used and should be removed

Test plan:
Search for "find_value" in the file and confirm that there is no more
occurrence
Comment 2 David Nind 2021-07-31 18:56:35 UTC
Created attachment 123353 [details] [review]
Bug 28765: Remove sub find_value from batchMod.pl

It has never been used and should be removed

Test plan:
Search for "find_value" in the file and confirm that there is no more
occurrence

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2021-08-11 06:52:56 UTC
Just came accross this myself.. the same function in additem is also not used as far as I can tell but you appear to have dealt with that in bug 27526.
Comment 4 Martin Renvoize 2021-08-11 06:53:48 UTC
Created attachment 123735 [details] [review]
Bug 28765: Remove sub find_value from batchMod.pl

It has never been used and should be removed

Test plan:
Search for "find_value" in the file and confirm that there is no more
occurrence

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2021-08-11 06:54:03 UTC
Trivial fix, PQA
Comment 6 Jonathan Druart 2021-08-16 10:05:15 UTC
Pushed to master for 21.11, thanks to everybody involved!