Summary: | Warn when viewing itemtypes.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | System Administration | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | RESOLVED DUPLICATE | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, gmcharlt, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the cause of unnecessary warning messages in the log files when accessing the Administration > Item types page in the staff interface.
Before this fix, multiple warning messages "[WARN] Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121." appeared in the log files.
|
Version(s) released in: | |
Attachments: |
Bug 28775: Pass interface to getTranslatedLanguages
Bug 28775: Pass interface to getTranslatedLanguages |
Description
Nick Clemens (kidclamp)
2021-07-28 13:11:29 UTC
Created attachment 123249 [details] [review] Bug 28775: Pass interface to getTranslatedLanguages Don't pass undef for interface, we are on the staff client To test: 1 - Browse to Administration -> Item types administration 2 - See in logs: [WARN] Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. 3 - Apply patch 4 - Reload page 5 - No warn Created attachment 123345 [details] [review] Bug 28775: Pass interface to getTranslatedLanguages Don't pass undef for interface, we are on the staff client To test: 1 - Browse to Administration -> Item types administration 2 - See in logs: [WARN] Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. 3 - Apply patch 4 - Reload page 5 - No warn Signed-off-by: David Nind <david@davidnind.com> It seems to me that this fix is too easy. Can be translated may well pertain to the OPAC (not staff only). For instance we use staff in English, but OPAC in Dutch and English. If you look at the module routine, you see that no interface means OPAC + Intranet in returned languages. Giving another result in the above scenario. Please adjust the routine? Passing empty string might be a cheap solution but probably not the nicest ;) |