Summary: | Action logs should capture lost items found | ||
---|---|---|---|
Product: | Koha | Reporter: | hebah |
Component: | Transaction logs | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, jonathan.druart, lucas, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Attachments: |
Bug 28799: Log when item was lost and now found
Bug 28799: Log when item was lost and now found Bug 28799: Log when item was lost and now found Bug 28799: Log when item was lost and now found Bug 28799: Log when item was lost and now found |
Description
hebah
2021-08-02 17:07:30 UTC
In master there is no action log when the item is checked in. On which version did you test? (In reply to Jonathan Druart from comment #1) > In master there is no action log when the item is checked in. > > On which version did you test? 20.05. I've updated ticket to reflect that. Should we remove the log then? Is the behaviour in master correct? Created attachment 123480 [details] [review] Bug 28799: Log when item was lost and now found In the subroutine ModDateLastSeen we unset an item's lost status when checked in. This routine passes a noi log parameter to the store request, this is to avoid spamming the cataloguing log on every checkin. When marking an item unlost we should record this change. To test: 1 - Enable cataloguing log 2 - Mark an item lost 3 - View the log and confirm this chagne was recorded 4 - Check the item in 5 - The message indicates item is now found, but logs have no new entry 6 - Apply patch, restart all 7 - Mark the item lost and verify it is logged 8 - Check the item in, reported found and log entry recorded Created attachment 123530 [details] [review] Bug 28799: Log when item was lost and now found In the subroutine ModDateLastSeen we unset an item's lost status when checked in. This routine passes a noi log parameter to the store request, this is to avoid spamming the cataloguing log on every checkin. When marking an item unlost we should record this change. To test: 1 - Enable cataloguing log 2 - Mark an item lost 3 - View the log and confirm this chagne was recorded 4 - Check the item in 5 - The message indicates item is now found, but logs have no new entry 6 - Apply patch, restart all 7 - Mark the item lost and verify it is logged 8 - Check the item in, reported found and log entry recorded Signed-off-by: Owen Leonard <oleonard@myacpl.org> I think you should take leave_item_lost into account. Also we need tests to cover the changes. Additional question, do we really want a cataloguing log when an item is modified outside of the cataloguing module? (In reply to Jonathan Druart from comment #6) > I think you should take leave_item_lost into account. > > Also we need tests to cover the changes. > > Additional question, do we really want a cataloguing log when an item is > modified outside of the cataloguing module? I think yes, if you decide to log changes to something, it should not matter where it is changed, you want to know when it changed and who did it. Created attachment 140831 [details] [review] Bug 28799: Log when item was lost and now found In the subroutine ModDateLastSeen we unset an item's lost status when checked in. This routine passes a noi log parameter to the store request, this is to avoid spamming the cataloguing log on every checkin. When marking an item unlost we should record this change. To test: 1 - Enable cataloguing log 2 - Mark an item lost 3 - View the log and confirm this chagne was recorded 4 - Check the item in 5 - The message indicates item is now found, but logs have no new entry 6 - Apply patch, restart all 7 - Mark the item lost and verify it is logged 8 - Check the item in, reported found and log entry recorded Created attachment 140849 [details] [review] Bug 28799: Log when item was lost and now found In the subroutine ModDateLastSeen we unset an item's lost status when checked in. This routine passes a noi log parameter to the store request, this is to avoid spamming the cataloguing log on every checkin. When marking an item unlost we should record this change. To test: 1 - Enable cataloguing log 2 - Mark an item lost 3 - View the log and confirm this chagne was recorded 4 - Check the item in 5 - The message indicates item is now found, but logs have no new entry 6 - Apply patch, restart all 7 - Mark the item lost and verify it is logged 8 - Check the item in, reported found and log entry recorded Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 141542 [details] [review] Bug 28799: Log when item was lost and now found In the subroutine ModDateLastSeen we unset an item's lost status when checked in. This routine passes a noi log parameter to the store request, this is to avoid spamming the cataloguing log on every checkin. When marking an item unlost we should record this change. To test: 1 - Enable cataloguing log 2 - Mark an item lost 3 - View the log and confirm this chagne was recorded 4 - Check the item in 5 - The message indicates item is now found, but logs have no new entry 6 - Apply patch, restart all 7 - Mark the item lost and verify it is logged 8 - Check the item in, reported found and log entry recorded Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! Doesn't apply cleanly to 22.05.x, no backport |