| Summary: | Untranslatable strings in browser.js | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Staff interface | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | Pushed to oldoldoldstable --- | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle, tomascohen, victor, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.03,20.11.10,20.05.16,19.11.22
|
|
| Circulation function: | |||
| Bug Depends on: | 25321 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 28802: Untranslatable strings in browser.js
Bug 28802: Untranslatable strings in browser.js Bug 28802: Untranslatable strings in browser.js Bug 28802: Fix Asset.t |
||
|
Description
Fridolin Somers
2021-08-03 07:10:30 UTC
Caused by: commit 5fa99d7d59ffe65a3533c79a637b50f04e904736 Bug 25321: Move translatable strings out of strings.inc into the corresponding JavaScript Created attachment 123408 [details] [review] Bug 28802: Untranslatable strings in browser.js File koha-tmpl/intranet-tmpl/js/browser.js is not parsed by translation process, which uses koha-tmpl/intranet-tmpl/prog/js/**/*.js We must move it to prog/js. Test plan : 1) Perform a search on staff interface 2) Click on a result 3) Check you see records browser Created attachment 123411 [details] [review] Bug 28802: Untranslatable strings in browser.js File koha-tmpl/intranet-tmpl/js/browser.js is not parsed by translation process, which uses koha-tmpl/intranet-tmpl/prog/js/**/*.js We must move it to prog/js. Test plan : 1) Perform a search on staff interface 2) Click on a result 3) Check you see records browser Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 123875 [details] [review] Bug 28802: Untranslatable strings in browser.js File koha-tmpl/intranet-tmpl/js/browser.js is not parsed by translation process, which uses koha-tmpl/intranet-tmpl/prog/js/**/*.js We must move it to prog/js. Test plan : 1) Perform a search on staff interface 2) Click on a result 3) Check you see records browser Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Shouldn't we actually move all the JS files to koha-tmpl/intranet-tmpl/prog/js? Pushed to master for 21.11, thanks to everybody involved! Created attachment 123962 [details] [review] Bug 28802: Fix Asset.t (In reply to Jonathan Druart from comment #7) > Created attachment 123962 [details] [review] [review] > Bug 28802: Fix Asset.t Patch pushed to master. (In reply to Jonathan Druart from comment #5) > Shouldn't we actually move all the JS files to > koha-tmpl/intranet-tmpl/prog/js? I think yes but I can not confirm. Pushed to 21.05.x for 21.05.03 Pushed to 20.11.x for 20.11.10 Backported: Pushed to 20.05.x branch for 20.05.16 Should this be backported to 19.11.x for 19.11.22? Even if the severity is "normal" I backported it since it's about translation and it applied without issues. I do that with accessibility stuff also. Your call if you feel backporting some additional things those. Backported to 19.11.x for 19.11.22 |