Summary: | Authority tag editor only copies $a from record to search form | ||
---|---|---|---|
Product: | Koha | Reporter: | Didier Gautheron <didier.gautheron> |
Component: | Cataloging | Assignee: | Didier Gautheron <didier.gautheron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | bernard.scaife, fridolin.somers, jonathan.druart, kyle, m.de.rooy, nick, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.11.00,21.05.04,20.11.10
|
Circulation function: | |
Bug Depends on: | 7882 | ||
Bug Blocks: | |||
Attachments: |
Bug 28812: (bug 7882 follow up) Copy all subfields in plugin editor
Bug 28812: (bug 7882 follow up) Copy all subfields in plugin editor Bug 28812: (bug 7882 follow up) Copy all subfields in plugin editor Bug 28812: Improve robustness of selector |
Description
Didier Gautheron
2021-08-04 14:51:42 UTC
Didier, are you going to submit a patch with your proposed changes? Yes but I have to double check first it doesn't break in authorities/authorities.pl This reads quite similar to bug 28738 - maybe a similar fix would work? I can't reproduce this issue on master? Maybe I am testing the wrong thing. Do you mean copying a repeatable field or are we talking about the authority linker? Authority editor or editing bibliographic records? (In reply to Katrin Fischer from comment #5) > Maybe I am testing the wrong thing. > > Do you mean copying a repeatable field or are we talking about the authority > linker? > Authority editor or editing bibliographic records? Authority search Window. 1- Create a notice with a 700$a and 700$d 2- Click on 700 $a field Tag Editor 3- Only 700$a is copied in search windows eg /authorities/auth_finder.pl pop up 4- Apply patch 5- Redo 2 6- as in 19.11 700$a is copied in 'Search main heading ($a only)' and $d is copied in 'Search main heading' (In reply to Didier Gautheron from comment #7) > 4- Apply patch Which one? :) Created attachment 124116 [details] [review] Bug 28812: (bug 7882 follow up) Copy all subfields in plugin editor To test: 1- Create a notice with a 700$a and 700$d 2- Click on 700 $a field Tag Editor 3- Only 700$a is copied in search windows eg /authorities/auth_finder.pl pop up 4- Apply patch 5- Redo 2 6- 700$a is copied in 'Search main heading ($a only)' and $d is copied in 'Search main heading' (In reply to Jonathan Druart from comment #8) > (In reply to Didier Gautheron from comment #7) > > 4- Apply patch > > Which one? :) The one I forgot to add :) Created attachment 124175 [details] [review] Bug 28812: (bug 7882 follow up) Copy all subfields in plugin editor To test: 1- Create a notice with a 700$a and 700$d 2- Click on 700 $a field Tag Editor 3- Only 700$a is copied in search windows eg /authorities/auth_finder.pl pop up 4- Apply patch 5- Redo 2 6- 700$a is copied in 'Search main heading ($a only)' and $d is copied in 'Search main heading' Signed-off-by: George Veranis <gveranis@dataly.gr> Created attachment 124232 [details] [review] Bug 28812: (bug 7882 follow up) Copy all subfields in plugin editor To test: 1- Create a notice with a 700$a and 700$d 2- Click on 700 $a field Tag Editor 3- Only 700$a is copied in search windows eg /authorities/auth_finder.pl pop up 4- Apply patch 5- Redo 2 6- 700$a is copied in 'Search main heading ($a only)' and $d is copied in 'Search main heading' Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> The proposed fix definitely works and fixes a bad bug. Bug 28828 is about the same issue and fount a slightly different solution that might be a little less prone to problems with future changes. Created attachment 124241 [details] [review] Bug 28812: Improve robustness of selector Use the same fix as bug 28828. Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.04 Pushed to 20.11.x, will be in 20.11.10 testing this on 20.05.x to backport: - create a new record with 700$a and 700$d populated - save - edit same record - go back to 700$a - open the Tag Editor - only the value of 700$a goes in "Search main heading ($a only): " - only the value of 700$d goes in "Search main heading: " Same with an without the patch Is what is happening expected? yes: so 20.05.x isn't affected no: there is an issue even with the patch Am I actually testing the right thing? *** Bug 28693 has been marked as a duplicate of this bug. *** |