Description
Martin Renvoize (ashimema)
2021-08-05 07:40:28 UTC
Created attachment 123471 [details] [review] Bug 28813: Update database field name Update the database field name from 'delivery_note' to 'failure_code' to more accurately denote it's use. Created attachment 123472 [details] [review] Bug 28813: DBIC Schema Update Created attachment 123473 [details] [review] Bug 28813: Update unit tests This patch updates the unit tests to check for failure_code instead of delivery_note and catches a missing case. Created attachment 123474 [details] [review] Bug 28813: Rename delivery_note to failure_code We now use the codes from the half implimented error_code in place of the plain text that was being added to the delivery_note field. As part of that we rename the field to failure_code to clarify it's intended content. Test plan 1/ Confirm t/db_dependent/Letters.t passes Created attachment 123536 [details] [review] Bug 28813: Update database field name Update the database field name from 'delivery_note' to 'failure_code' to more accurately denote it's use. Signed-off-by: David Nind <david@davidnind.com> Created attachment 123537 [details] [review] Bug 28813: DBIC Schema Update Signed-off-by: David Nind <david@davidnind.com> Created attachment 123538 [details] [review] Bug 28813: Update unit tests This patch updates the unit tests to check for failure_code instead of delivery_note and catches a missing case. Signed-off-by: David Nind <david@davidnind.com> Created attachment 123539 [details] [review] Bug 28813: Rename delivery_note to failure_code We now use the codes from the half implimented error_code in place of the plain text that was being added to the delivery_note field. As part of that we rename the field to failure_code to clarify it's intended content. Test plan 1/ Confirm t/db_dependent/Letters.t passes Signed-off-by: David Nind <david@davidnind.com> Testing notes (koha-testing-docker): - prove t/db_dependent/Letters.t (before apply patches) - apply patches - updatedatabase + dbic - flush_memcached - restart_all - prove t/db_dependent/Letters.t (tests should pass) Hope that is sufficient for testing. Created attachment 123667 [details] [review] Bug 28813: Update database field name Update the database field name from 'delivery_note' to 'failure_code' to more accurately denote it's use. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123668 [details] [review] Bug 28813: DBIC Schema Update Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123669 [details] [review] Bug 28813: Update unit tests This patch updates the unit tests to check for failure_code instead of delivery_note and catches a missing case. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123670 [details] [review] Bug 28813: Rename delivery_note to failure_code We now use the codes from the half implimented error_code in place of the plain text that was being added to the delivery_note field. As part of that we rename the field to failure_code to clarify it's intended content. Test plan 1/ Confirm t/db_dependent/Letters.t passes Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Tested similarly as David, additionally updated failure_code in my database to check the display on the notices tab. Maybe we could update the bug description a bit, keeping release notes in mind. Pushed to master for 21.11, thanks to everybody involved! (In reply to Katrin Fischer from comment #15) > Maybe we could update the bug description a bit, keeping release notes in > mind. Done. Pushed to 21.05.x for 21.05.03 Depends on Bug 14723 not in 20.11.x |