| Summary: | Can't edit local cover image for item from details page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.03
|
|
| Circulation function: | |||
| Bug Depends on: | 28179 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 28825: Can't edit local cover image for item from details page
Bug 28825: Can't edit local cover image for item from details page Bug 28825: Can't edit local cover image for item from details page Bug 28825: Can't edit local cover image for item from details page |
||
|
Description
Owen Leonard
2021-08-06 16:47:55 UTC
Created attachment 123584 [details] [review] Bug 28825: Can't edit local cover image for item from details page This patch corrects the markup for local cover images attached to items. The correction allows correct display of an "edit" link when the user clicks an item's cover image and views it in the lightbox-style modal. To test, apply the patch and make sure the "LocalCoverImages" system preference is enabled. - View the details of a bibliographic record in the catalog which has items attached.. - In the table of holdings, click Edit -> Upload image. - Upload an image for the item and return to the bibliographic detail page. - Your image should now be displayed in the holdings table. - Click the image to view it. - In the footer of the modal there is an edit link: "Local cover image (edit). Before this patch the edit link would lead to a missing page. After applying the patch the link should take you to the "Image view" where you have the option of deleting the image or uploading another one. Created attachment 123600 [details] [review] Bug 28825: Can't edit local cover image for item from details page This patch corrects the markup for local cover images attached to items. The correction allows correct display of an "edit" link when the user clicks an item's cover image and views it in the lightbox-style modal. To test, apply the patch and make sure the "LocalCoverImages" system preference is enabled. - View the details of a bibliographic record in the catalog which has items attached.. - In the table of holdings, click Edit -> Upload image. - Upload an image for the item and return to the bibliographic detail page. - Your image should now be displayed in the holdings table. - Click the image to view it. - In the footer of the modal there is an edit link: "Local cover image (edit). Before this patch the edit link would lead to a missing page. After applying the patch the link should take you to the "Image view" where you have the option of deleting the image or uploading another one. Signed-off-by: David Nind <david@davidnind.com> Created attachment 123663 [details] [review] Bug 28825: Can't edit local cover image for item from details page This patch corrects the markup for local cover images attached to items. The correction allows correct display of an "edit" link when the user clicks an item's cover image and views it in the lightbox-style modal. To test, apply the patch and make sure the "LocalCoverImages" system preference is enabled. - View the details of a bibliographic record in the catalog which has items attached.. - In the table of holdings, click Edit -> Upload image. - Upload an image for the item and return to the bibliographic detail page. - Your image should now be displayed in the holdings table. - Click the image to view it. - In the footer of the modal there is an edit link: "Local cover image (edit). Before this patch the edit link would lead to a missing page. After applying the patch the link should take you to the "Image view" where you have the option of deleting the image or uploading another one. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 123664 [details] [review] Bug 28825: Can't edit local cover image for item from details page This patch corrects the markup for local cover images attached to items. The correction allows correct display of an "edit" link when the user clicks an item's cover image and views it in the lightbox-style modal. To test, apply the patch and make sure the "LocalCoverImages" system preference is enabled. - View the details of a bibliographic record in the catalog which has items attached.. - In the table of holdings, click Edit -> Upload image. - Upload an image for the item and return to the bibliographic detail page. - Your image should now be displayed in the holdings table. - Click the image to view it. - In the footer of the modal there is an edit link: "Local cover image (edit). Before this patch the edit link would lead to a missing page. After applying the patch the link should take you to the "Image view" where you have the option of deleting the image or uploading another one. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.03 |