Summary: | SCO impossible errors are hard to target with CSS/JS | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass <lucas> |
Component: | OPAC | Assignee: | Lucas Gass <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This patch adds unique IDs to the SCO main page so the impossible errors can easily be targeted via JS and CSS.
|
Version(s) released in: |
21.11.00
|
Attachments: |
Bug 28838: add unique IDs to sco-main.tt impossible errors
Bug 28838: add unique IDs to sco-main.tt impossible errors Bug 28838: add unique IDs to sco-main.tt impossible errors |
Description
Lucas Gass
2021-08-10 14:17:12 UTC
Created attachment 123700 [details] [review] Bug 28838: add unique IDs to sco-main.tt impossible errors To test: 1. Apply patch 2. Go SCO and try to checkout some items that will generate some of the following errors: The system does not recognize this barcode. You have checked out too many items and can't check out any more. This item is checked out to someone else. You cannot renew this item again. This item is not for loan. You owe the library [% DEBT | $Price %] and cannot check out. This item has been withdrawn from the collection. This item is restricted. This item is on hold for another patron. This item belongs to another branch. Your account has expired. Your account has been suspended. This card has been declared lost. Your contact information seems to be incomplete. Due date is not valid. Item must be checked out at a circulation desk. 3. The display should be exactly as it was without the patch but if you use the browsers dev tools you should be able to inscept each error message and see that it is now wrapped in a <span> with an ID. Created attachment 123781 [details] [review] Bug 28838: add unique IDs to sco-main.tt impossible errors To test: 1. Apply patch 2. Go SCO and try to checkout some items that will generate some of the following errors: The system does not recognize this barcode. You have checked out too many items and can't check out any more. This item is checked out to someone else. You cannot renew this item again. This item is not for loan. You owe the library [% DEBT | $Price %] and cannot check out. This item has been withdrawn from the collection. This item is restricted. This item is on hold for another patron. This item belongs to another branch. Your account has expired. Your account has been suspended. This card has been declared lost. Your contact information seems to be incomplete. Due date is not valid. Item must be checked out at a circulation desk. 3. The display should be exactly as it was without the patch but if you use the browsers dev tools you should be able to inscept each error message and see that it is now wrapped in a <span> with an ID. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 124227 [details] [review] Bug 28838: add unique IDs to sco-main.tt impossible errors To test: 1. Apply patch 2. Go SCO and try to checkout some items that will generate some of the following errors: The system does not recognize this barcode. You have checked out too many items and can't check out any more. This item is checked out to someone else. You cannot renew this item again. This item is not for loan. You owe the library [% DEBT | $Price %] and cannot check out. This item has been withdrawn from the collection. This item is restricted. This item is on hold for another patron. This item belongs to another branch. Your account has expired. Your account has been suspended. This card has been declared lost. Your contact information seems to be incomplete. Due date is not valid. Item must be checked out at a circulation desk. 3. The display should be exactly as it was without the patch but if you use the browsers dev tools you should be able to inscept each error message and see that it is now wrapped in a <span> with an ID. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! |