Bug 28843

Created attachment 123804 [details] [review]
Bug 28843: Add view and edit buttons to result of MARC record import

This patch adds "View" and "Edit" buttons to the output of the result of
a MARC record import.

To test, apply the patch and go to Tools -> State MARC for import.

 - Import a file of MARC records.
 - Click the "Manage staged records" button.
 - In the table of staged records the last column labeled "Records"
   should be empty.
 - Click "Import this batch into the catalog."
 - The table of records will be shown again, and this time the last
   column should contain "View" and "Edit" buttons for each row.
 - Confirm that the buttons work correctly, opening the correct record
   for viewing and editing.

Test with both bibliographic and authority records to confirm that the
correct view and edit pages open for each.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>

I originally signed off on this bug, but had some concerns so I revisited it and changed the status to In Discussion.

1. A staff member who does not have edit permissions still sees the edit button.  Clicking on the edit button takes them to a Koha login screen.  It would be better if the staff member did not see the edit button at all if they can't edit anything.

2. When a staff member that does not have bib editing permissions clicks on the View button from manage-marc-import.pl they are taken to a view only display on detail.pl which seems correct.  However, clicking on the Edit dropdown on this screen gives them the ability to edit the record using a MARC mod template even though they do not have the permission for editing these templates.  A staff member with view only permissions should not be able to edit the bib record at all. 

3. In discussing this issue with an expert cataloger she had the following to say:
"I can't think of a single reason why I'd allow someone to load files without any editing permissions, frankly--looking at a loaded file is a quality control step, and if someone doesn't have the expertise to edit MARC (bib or aut), how are they going to have the expertise to, e.g., troubleshoot something that should have overlaid but didn't?"  Based on this comment it seems she would question whether a view option is even needed.

(In reply to Barbara Johnson from comment #3)
> 
> 2. ...However, clicking on the Edit
> dropdown on this screen gives them the ability to edit the record using a
> MARC mod template even though they do not have the permission for editing
> these templates.

This sounds like it needs a new bug report.

> 3. ... Based on this
> comment it seems she would question whether a view option is even needed.

The view option was always there, it was just unclear what it was because the link was just a number.

Marking "Failed QA" in order to address issue 1.

Created attachment 123938 [details] [review]
Bug 28843: Add view and edit buttons to result of MARC record import

This patch adds "View" and "Edit" buttons to the output of the result of
a MARC record import.

To test, apply the patch and go to Tools -> State MARC for import.

 - Import a file of MARC records.
 - Click the "Manage staged records" button.
 - In the table of staged records the last column labeled "Records"
   should be empty.
 - Click "Import this batch into the catalog."
 - The table of records will be shown again, and this time the last
   column should contain "View" and "Edit" buttons for each row.
 - Confirm that the buttons work correctly, opening the correct record
   for viewing and editing.

Test with both bibliographic and authority records to confirm that the
correct view and edit pages open for each.

EDIT: Add permission check for "Edit" link

Super, I like that

Created attachment 123986 [details] [review]
Bug 28843: Add view and edit buttons to result of MARC record import

This patch adds "View" and "Edit" buttons to the output of the result of
a MARC record import.

To test, apply the patch and go to Tools -> State MARC for import.

 - Import a file of MARC records.
 - Click the "Manage staged records" button.
 - In the table of staged records the last column labeled "Records"
   should be empty.
 - Click "Import this batch into the catalog."
 - The table of records will be shown again, and this time the last
   column should contain "View" and "Edit" buttons for each row.
 - Confirm that the buttons work correctly, opening the correct record
   for viewing and editing.

Test with both bibliographic and authority records to confirm that the
correct view and edit pages open for each.

EDIT: Add permission check for "Edit" link
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

I like :)

Created attachment 124220 [details] [review]
Bug 28843: Add view and edit buttons to result of MARC record import

This patch adds "View" and "Edit" buttons to the output of the result of
a MARC record import.

To test, apply the patch and go to Tools -> State MARC for import.

 - Import a file of MARC records.
 - Click the "Manage staged records" button.
 - In the table of staged records the last column labeled "Records"
   should be empty.
 - Click "Import this batch into the catalog."
 - The table of records will be shown again, and this time the last
   column should contain "View" and "Edit" buttons for each row.
 - Confirm that the buttons work correctly, opening the correct record
   for viewing and editing.

Test with both bibliographic and authority records to confirm that the
correct view and edit pages open for each.

EDIT: Add permission check for "Edit" link
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Pushed to master for 21.11, thanks to everybody involved!