Summary: | OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Joonas Kylmälä <joonas.kylmala> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, joonas.kylmala, kyle, martin.renvoize, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05,20.11.11
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 28847 | ||
Attachments: |
Bug 28845: Match against the full limit string, not just the group id
Bug 28845: Match against the full limit string, not just the group id Bug 28845: (follow-up) Retain selection when using advanced search Bug 28845: Match against the full limit string, not just the group id Bug 28845: (follow-up) Retain selection when using advanced search |
Description
Nick Clemens (kidclamp)
2021-08-11 15:30:29 UTC
Created attachment 123799 [details] [review] Bug 28845: Match against the full limit string, not just the group id To test: 1 - Add to OPAC virtual host in apache conf: SetEnv OPAC_SEARCH_LIMIT branch:multibranch-1 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-1" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 2 - Enable system preference OpacAddMastheadLibraryPulldown 3 - Create a library group enabled as OPAC search group (or make sure existing group 1 is an OPAC search group) 4 - Load the opac - dropdown does not pree-select the search group 5 - Apply patch 6 - Relaod opac - group is pre-selected! Created attachment 123828 [details] [review] Bug 28845: Match against the full limit string, not just the group id To test: 1 - Add to OPAC virtual host in apache conf: SetEnv OPAC_SEARCH_LIMIT branch:multibranch-1 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-1" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 2 - Enable system preference OpacAddMastheadLibraryPulldown 3 - Create a library group enabled as OPAC search group (or make sure existing group 1 is an OPAC search group) 4 - Load the opac - dropdown does not pree-select the search group 5 - Apply patch 6 - Relaod opac - group is pre-selected! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> This patch breaks the group selection in OPAC advanced search, i.e. with this patch applied if you go to the URL http://localhost:8080/cgi-bin/koha/opac-search.pl?advsearch=1&weight_search=1&multibranchlimit=1&sort_by=relevance&do=Search then the group doesn't get selected in the search menu. Created attachment 124573 [details] [review] Bug 28845: (follow-up) Retain selection when using advanced search (In reply to Joonas Kylmälä from comment #3) > This patch breaks the group selection in OPAC advanced search, i.e. with > this patch applied if you go to the URL > > http://localhost:8080/cgi-bin/koha/opac-search. > pl?advsearch=1&weight_search=1&multibranchlimit=1&sort_by=relevance&do=Search > > > then the group doesn't get selected in the search menu. Updated, stole a change from 28847 :-) Created attachment 124791 [details] [review] Bug 28845: Match against the full limit string, not just the group id To test: 1 - Add to OPAC virtual host in apache conf: SetEnv OPAC_SEARCH_LIMIT branch:multibranch-1 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-1" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 2 - Enable system preference OpacAddMastheadLibraryPulldown 3 - Create a library group enabled as OPAC search group (or make sure existing group 1 is an OPAC search group) 4 - Load the opac - dropdown does not pree-select the search group 5 - Apply patch 6 - Relaod opac - group is pre-selected! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Created attachment 124792 [details] [review] Bug 28845: (follow-up) Retain selection when using advanced search Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 Pushed to 20.11.x for 20.11.11 Can't backport to 20.05.x due to a conflict. The relevant code isn't there ([% IF lsg.id == opac_name %]) Help needed if someone is interested in the backport. I couldn't reproduce but I'm not sure if I did it right or if 20.05.x isn't affected. On request I can try with 20.11.x to check if did the test plan correctly. |