Summary: | OpenAPI version should be a string | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | REST API | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
Circulation function: | |||
Attachments: |
Bug 28848: Make sure the 'swagger' attribute is a string
Bug 28848: Make sure the 'swagger' attribute is a string Bug 28848: Make sure the 'swagger' attribute is a string |
Description
Tomás Cohen Arazi (tcohen)
2021-08-12 13:29:55 UTC
Created attachment 123815 [details] [review] Bug 28848: Make sure the 'swagger' attribute is a string Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I'm not sure how this should be tested. Just see "2.0" is wrapped in double quotes, which is what the spec expects as mentioned. Created attachment 123818 [details] [review] Bug 28848: Make sure the 'swagger' attribute is a string Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Testing notes (koha-testing-docker): 1. Go to https://editor.swagger.io/ 2. Load the api/v1/swagger/swagger.yaml file (File > Import file) 3. You should get this message: Unable to render this definition The provided definition does not specify a valid version field. Please indicate a valid Swagger or OpenAPI version field. Supported version fields are swagger: "2.0" and those that match openapi: 3.0.n (for example, openapi: 3.0.0). 4. Apply the patch 5. Repeat steps 1-2 6. The file should now load Created attachment 123823 [details] [review] Bug 28848: Make sure the 'swagger' attribute is a string Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Obvious fix.. PQA Pushed to master for 21.11, thanks to everybody involved! |