Summary: | Masthead.inc is missing class name | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass <lucas> |
Component: | OPAC | Assignee: | Lucas Gass <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, kyle, sally.healey, victor |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This patch adds back the class 'mastheadsearch' which was lost during the upgrade to Bootstrap 4 in Bug 20168.
|
Version(s) released in: |
21.11.00,21.05.03,20.11.09
|
Bug Depends on: | 20168 | ||
Bug Blocks: | |||
Attachments: |
Bug 28868: Add back mastheadsearch class name
Bug 28868: Add back mastheadsearch class name Bug 28868: Add back mastheadsearch class name Bug 28868: Add back mastheadsearch class name |
Description
Lucas Gass
2021-08-16 21:21:40 UTC
Created attachment 123863 [details] [review] Bug 28868: Add back mastheadsearch class name Test plan: 1. Inscept the element on the OPAC main page and see the element with an ID of 'opac-main-search'. 2. Apply patch 3. Inscept that same element and you should now also see a class of 'mastheadsearch'. 4. Nothing visually should be different with the patch applied. Mmm this is changed since 20.11.00. We at Biblibre have fixed each broken customisation of OPAC. This is not the only change, and for me it makes sens to have an id instead of a class for a tag existing only once in the page. (In reply to Fridolin Somers from comment #2) > Mmm this is changed since 20.11.00. > We at Biblibre have fixed each broken customisation of OPAC. > This is not the only change, and for me it makes sens to have an id instead > of a class for a tag existing only once in the page. Why can't it have both? (In reply to Lucas Gass from comment #3) > (In reply to Fridolin Somers from comment #2) > > Mmm this is changed since 20.11.00. > > We at Biblibre have fixed each broken customisation of OPAC. > > This is not the only change, and for me it makes sens to have an id instead > > of a class for a tag existing only once in the page. > > Why can't it have both? It can, I'm not against it. Created attachment 123933 [details] [review] Bug 28868: Add back mastheadsearch class name Test plan: 1. Inscept the element on the OPAC main page and see the element with an ID of 'opac-main-search'. 2. Apply patch 3. Inscept that same element and you should now also see a class of 'mastheadsearch'. 4. Nothing visually should be different with the patch applied. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Works as described - thanks Lucas! Created attachment 123936 [details] [review] Bug 28868: Add back mastheadsearch class name Test plan: 1. Inscept the element on the OPAC main page and see the element with an ID of 'opac-main-search'. 2. Apply patch 3. Inscept that same element and you should now also see a class of 'mastheadsearch'. 4. Nothing visually should be different with the patch applied. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Lucas, don't forget the commit message to describe a bit the context please (not only the commit title) Created attachment 123960 [details] [review] Bug 28868: Add back mastheadsearch class name In masthead.inc there is a wrapper for the main search bar called #opac-main-search. Prior to Bug 20168 that warpper had a class name of 'mastheadsearch'. Historically CSS/JS customization of the main search bar was done via the mastheadsearch class. Test plan: 1. Inscept the element on the OPAC main page and see the element with an ID of 'opac-main-search'. 2. Apply patch 3. Inscept that same element and you should now also see a class of 'mastheadsearch'. 4. Nothing visually should be different with the patch applied. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.03 I very much appreciate everyone's efforts on this one, thanks! Pushed to 20.11.x for 20.11.09 Missing dependencies for 20.05.x, it shouldn't be affected, no backport. |